After pushing, wait for MRs to stabilize #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By stabililze we mean that the "changes_count" field of the MR has a value of "1". This ensures that by the time the "git lab" command terminates, MRs should be fully up-to-date. Note that this approach will have to be reevaluated if #16 is implemented (which would allow multiple commits to end up in a single MR). Also: unit_tests/merge_request_test.py: MergeRequestTest: Removed WAIT_TIME_BEFORE_VALIDATE, etc since create_merge_requests() now waits for the desired state before returning. Change-Id: Id20d9feb27076afe0603bee334badc815e5528a9
dancysoft
force-pushed
the
review/dancy/wait-for-stable
branch
from
7ee3c16 to
3ccdfea
Compare
dancysoft
pushed a commit
that referenced
this pull request
Aug 30, 2023
Followup to #35 Change-Id: I209472650081fc3b32181af41d9ddc30c344adb5
dancysoft
pushed a commit
that referenced
this pull request
Aug 30, 2023
Followup to #35 Change-Id: I209472650081fc3b32181af41d9ddc30c344adb5
dancysoft
pushed a commit
that referenced
this pull request
Aug 30, 2023
Followup to #35 Change-Id: I209472650081fc3b32181af41d9ddc30c344adb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By stabililze we mean that the "changes_count" field of the MR has a value of "1". This ensures that by the time the "git lab" command terminates, MRs should be fully up-to-date.
Note that this approach will have to be reevaluated if #16 is implemented (which would allow multiple commits to end up in a single MR).
Also:
unit_tests/merge_request_test.py:
MergeRequestTest:
Removed WAIT_TIME_BEFORE_VALIDATE, etc since create_merge_requests()
now waits for the desired state before returning.