Create resource ydb_topic_consumer #6 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasha108bik
force-pushed
the
feature/create-resource-6
branch
from
28f56a6 to
536f8a4
Compare
rasha108bik
force-pushed
the
feature/create-resource-6
branch
2 times, most recently
from
bcc9564 to
045a1c3
Compare
shmel1k
requested changes
Mar 3, 2023
Makefile
Outdated
| @@ -9,4 +9,4 @@ local-build: | |||
| go build -o $(HOME)/.terraform.d/plugins/terraform.storage.ydb.tech/provider/ydb/$(SEMVER)/$(shell go env GOOS)_$(shell go env GOARCH)/terraform-provider-ydb main.go | |||
|
|
|||
| build: | |||
| go build -o bin/terraform-provider-ydb main.go | |||
| go build -o bin/terraform-provider-ydb main.go | |||
internal/helpers/topic/topic.go
Outdated
| @@ -40,101 +36,6 @@ var ( | |||
| } | |||
| ) | |||
|
|
|||
| func MergeConsumerSettings( | |||
There was a problem hiding this comment.
Это нужно оставить. Как минимум, для обратной совместимости с тем, что было.
Код топиков почти используется(ждёт релиза) здесь: https://github.com/yandex-cloud/terraform-provider-yandex
Представим, что кто-то из пользователей завяжется на эту логику. И ему всё, очевидно, разнесёт
rasha108bik
force-pushed
the
feature/create-resource-6
branch
from
088717a to
fecc8de
Compare
shmel1k
requested changes
Mar 6, 2023
Comment on lines
115
to
118
| "service_type": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
Мне почему-то кажется, что это не используется...
Давай спилим
Comment on lines
96
to
99
| "name": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.NoZeroValues, |
There was a problem hiding this comment.
Давай сюда добавим ForceNew: true
Comment on lines
92
to
95
| "database_endpoint": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, |
There was a problem hiding this comment.
Давай добавим сюда ForceNew: true
И поменяем database_endpoint на connection_string
Comment on lines
96
to
99
| "name": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.NoZeroValues, |
There was a problem hiding this comment.
А где путь до топика? Его точно хочется уметь задавать
rasha108bik
force-pushed
the
feature/create-resource-6
branch
4 times, most recently
from
94e124a to
dcf74e9
Compare
shmel1k
requested changes
Mar 17, 2023
Comment on lines
+89
to
+93
| "connection_string": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| ForceNew: true, | ||
| }, |
rasha108bik
force-pushed
the
feature/create-resource-6
branch
from
e4cb5e8 to
dc1e470
Compare
rasha108bik
force-pushed
the
feature/create-resource-6
branch
from
dc1e470 to
738d93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6