set session status when closeOnce() is called instead of Close()
#1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.com/ydb-platform/ydb-go-sdk/v3incompatible changesVersion: value changed from "3.110.0" to "3.110.1" summaryBase version: v3.110.1-0.20250611115929-80221306ffea (master) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1806 +/- ##
==========================================
- Coverage 70.69% 70.65% -0.04%
==========================================
Files 385 385
Lines 40211 40211
==========================================
- Hits 28426 28412 -14
- Misses 10611 10623 +12
- Partials 1174 1176 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qrort
force-pushed
the
v3.108.5+CloseOnce
branch
3 times, most recently
from
fa467d2 to
43b8ede
Compare
qrort
force-pushed
the
v3.108.5+CloseOnce
branch
from
43b8ede to
8fe719b
Compare
kprokopenko
reviewed
Jun 23, 2025
| }, xtest.StopAfter(time.Second)) | ||
| } | ||
|
|
||
| func TestSessionCoreAttachError(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
These tests pass on the master branch. Could you add a test that reproduces the problem, i.e., fails on the master branch?
7 tasks
Collaborator
Author
|
reopened in #1824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
session status can be wrong, and users can sometimes experience timout when using
ExecuteDataQueryOverQueryServiceIssue Number: N/A
What is the new behavior?
fix resolves a concrete example of degradation on https://github.com/yandex/temporal-over-ydb/
Other information