Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 82.68% 82.72% +0.03%
==========================================
Files 99 99
Lines 12961 12969 +8
Branches 1269 1273 +4
==========================================
+ Hits 10717 10728 +11
+ Misses 1793 1791 -2
+ Partials 451 450 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dimastark
marked this pull request as ready for review
October 7, 2026 08:28
Member
|
Hi @dimastark, thanks for the contribution! We don’t actively maintain the Table Service API and plan to remove it in the future. Unless this change addresses a specific problem for a user, I’d prefer to leave this part of the code as it is. As a wise man once said, “Работает - не трогай” 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
ydb.aio.SessionPool._get_session_from_queue()leaves itsEvent.wait()task pending after a successful queued acquisition or a timeout. Repeated queued acquisitions therefore accumulate stop-waiter tasks until the pool stops. Cancelling an acquisition can also lose a session that was dequeued just before cancellation.Issue Number: N/A
What is the new behavior?
Both queue and stop helper tasks are cancelled when unfinished and awaited before acquisition completes, following the existing cleanup pattern in
ydb/aio/_utilities.py. A dequeued session abandoned by cancellation is returned with its original queue priority; after shutdown it is destroyed without starting a replacement. The timeout and existing shutdown behavior are preserved.Nine deterministic unit tests cover repeated queued acquisitions, positive and nonpositive timeouts, cancellation, and shutdown races using a real pool, queues and events with a mocked driver. All nine fail against the original implementation and pass with the fix. The tests are in the existing
ydb/table_test.pyand require no YDB server.Other information
Local validation on Python 3.11.16 / macOS:
tox -e blacktox -e styletox -e mypy— no issues in 108 source filestox -e py -- ydb -v— 247 tests passedDocker integration tests were not run locally.