Repository navigation
Add concurrent transactional Query RMW SLO workload - #922
Open
KirillKurdyukov wants to merge 1 commit into
Open
KirillKurdyukov wants to merge 1 commit into
KirillKurdyukov wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/slo-kv-checks-20261014 #922 +/- ##
===========================================================
Coverage 82.69% 82.69%
===========================================================
Files 99 99
Lines 12961 12961
Branches 1269 1269
===========================================================
Hits 10718 10718
Misses 1793 1793
Partials 450 450
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
Depends on #921 and targets
fix/slo-kv-checks-20261014, so this review containsonly the new RMW scenario, not the basic-KV fixes or historical QA changes.
Changes
entrypoint. Other adapters, basic KV and Topic remain unchanged.
atomic ledger/counter update. Exact replay cannot increment twice.
operation/payload and each counter's value/version.
metrics. Technical attempts include session acquisition before the callback.
acknowledged creations.
Verification
Mypy covers the existing SDK target, not the SLO harness.
tables: 12 logical writes and 30 SDK attempts each. The real OTLP receiver
confirmed logical/attempt counters, pending zero and client HDR percentiles.
coherent ledger/counter deletion, wrong version/payload and a final SDK
error each failed the process.
before its raw response was withheld from the transaction wrapper.
Undetermined recovery used the same ID, two attempts and one replay, with
unchanged exact persisted state. This is SDK response-boundary fault
evidence, not a physically dropped network packet.
Acceptance boundary
Hosted SLO and the final Linux current/baseline image pair remain unverified.
The existing SLO label gate is unchanged. No old green run is reused as proof.
Concurrent same-ref telemetry uses the already-supported unique
SLO_INSTANCE_ID; the existing default-instance collision is not claimed fixed.Passing tests retain existing SDK warnings. No SDK libraries, dependencies,
retry limits/backoff/deadlines, metrics definitions or Dockerfiles changed.