test: Adds unit tests for server (#16)

.github/workflows/main.yml

@@ -43,4 +43,4 @@ jobs:
           go-version-file: "go.mod"
 
       - name: Unit tests
-        run: go test ./... -cover
+        run: go test -p 1 -cover ./...

CONTRIBUTING.md

@@ -10,5 +10,5 @@
 ## Running Tests
 
 ```bash
-go test ./... -cover
+go test -p 1 -cover ./...
 ```

network/udpserver.go

@@ -70,8 +70,20 @@ func (udpServer *UdpServer) listen() {
 	}
 }
 
-func (udpServer *UdpServer) Close() {
-	close(udpServer.closeCh)
-	udpServer.conn.Close()
+func (udpServer *UdpServer) Close() error {
+	var err error
+	select {
+	case <-udpServer.closeCh:
+	default:
+		close(udpServer.closeCh)
+	}
+
+	if udpServer.conn != nil {
+		err = udpServer.conn.Close()
+	} else {
+		fmt.Printf("UDP server was not running\n")
+	}
+
 	udpServer.wg.Wait()
+	return err
 }

server/server_test.go

@@ -0,0 +1,44 @@
+package server_test
+
+import (
+	"testing"
+
+	"github.com/dot-5g/pfcp/server"
+)
+
+func TestServer(t *testing.T) {
+	t.Run("TestMoreThanOneServer", MoreThanOneServer)
+	t.Run("TestServerClosedNoError", ServerClosedNoError)
+}
+
+func MoreThanOneServer(t *testing.T) {
+	server1 := server.New("127.0.0.1:8805")
+	server2 := server.New("127.0.0.1:8805")
+
+	err1 := server1.Run()
+	err2 := server2.Run()
+	defer server1.Close()
+	defer server2.Close()
+
+	if err1 != nil {
+		t.Errorf("Expected no error to be returned")
+	}
+
+	if err2 == nil {
+		t.Errorf("Expected error to be returned")
+	}
+}
+
+func ServerClosedNoError(t *testing.T) {
+	server := server.New("127.0.0.1:8805")
+	server.Run()
+	server.Close()
+
+	err := server.Run()
+	defer server.Close()
+
+	if err != nil {
+		t.Errorf("Expected no error to be returned")
+	}
+
+}

tests/heartbeat_test.go

@@ -41,8 +41,7 @@ func HandleHeartbeatResponse(sequenceNumber uint32, recoveryTimeStamp ie.Recover
 
 func TestHeartbeat(t *testing.T) {
 	t.Run("TestHeartbeatRequest", HeartbeatRequest)
-	// t.Run("TestHeartbeatResponse", HeartbeatResponse)
-
+	t.Run("TestHeartbeatResponse", HeartbeatResponse)
 }
 
 func HeartbeatRequest(t *testing.T) {
@@ -84,6 +83,8 @@ func HeartbeatResponse(t *testing.T) {
 	sentSequenceNumber := uint32(971)
 	recoveryTimeStamp := ie.NewRecoveryTimeStamp(time.Now())
 
+	pfcpServer.Run()
+
 	defer pfcpServer.Close()
 
 	time.Sleep(time.Second)