This repository was archived by the owner on Mar 26, 2018. It is now read-only.
rewrite the sourceMappingURL in maps #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great if this got merged! 👍 |
| // rewrite the sourceMappingURL in files | ||
| var jsFileContents = fs.readFileSync(resultPath, { | ||
| encoding: 'utf8' | ||
| }); |
There was a problem hiding this comment.
use the grunt file API methods
|
Also needs tests. |
|
@ncthis can you update with the code review comments please? |
|
---> #80 |
|
When this fix will be released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the filerev encounter sourcemaps, it will rename the sourcemaps. However, it will not rename the reference to the sourcemaps within the actual js file. This would result in browser 404s for these source maps.
This fix reads the file contents and updates the sourecemap names with the
revd name.