Skip to content

Fix for Web Workers #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for Web Workers #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions msgpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,12 @@
// Node.js
module.exports = msgpack;
}
else {
// Global object
else if (typeof WorkerGlobalScope === "function" && self instanceof WorkerGlobalScope) {
// Web Worker scope
self.msgpack = msgpack;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense (or is it even possible) to let the name "msgpack" be configured in this case as well like for the browser below?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, since a web worker runs in a different execution thread and has no access to the window object.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even on main document, the self or globalThis is valid, can check and use it in both world?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ygoe any news on the PR?

even on main document, the self or globalThis is valid, can check and use it in both world?

Not sure what do you mean.
I am using the self object because of how script importing works in a Web Worker scope.

In a browser scope, I am not sure what would the difference be between using self or window, but I'm guessing it's the same.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like self has been here since forever. Didn't know that.

So maybe the solution would be to just replace window with self everywhere? No additional check case needed.

}
else if (typeof window === "object") {
// Web browser
window[window.msgpackJsName || "msgpack"] = msgpack;
}

Expand Down