Feat/slashing yn eth #220
Feat/slashing yn eth #220
Conversation
|
On Holesky Failing tests: Encountered 1 failing test in test/scenarios/fork/ynETH/ProtocolUpgrade-Scenario.spec.sol:ProtocolUpgradeScenario Encountered 1 failing test in test/scenarios/fork/ynETH/Withdrawals.t.sol:M3WithdrawalsTest Encountered 1 failing test in test/scenarios/fork/ynETH/WithdrawalsWithRewards-Scenario.t.sol:M3WithdrawalsWithRewardsTest Encountered 2 failing tests in test/scenarios/ynEIGEN/Delegation.t.sol:YnEigenDelegationScenarioTest |
src/StakingNode.sol
Outdated
| */ | ||
| mapping(bytes32 withdrawalRoot => uint256 withdrawableShares) public withdrawableSharesForWithdrawalRoot; | ||
|
|
||
| /** @dev Allows only a whitelisted address to configure the contract */ |
There was a problem hiding this comment.
Why was the comment formatted into a one liner?
src/StakingNode.sol
Outdated
| */ | ||
| function syncQueuedShares() external onlyDelegator { | ||
|
|
||
| IDelegationManager delegationManager = IDelegationManager(address(stakingNodesManager.delegationManager())); |
There was a problem hiding this comment.
| IDelegationManager delegationManager = IDelegationManager(address(stakingNodesManager.delegationManager())); | |
| IDelegationManager delegationManager = stakingNodesManager.delegationManager(); |
Casting seems unnecessary.
The |
| // SPDX-License-Identifier: BSD 3-Clause License | ||
| pragma solidity ^0.8.24; | ||
|
|
||
| contract MockAVS { |
There was a problem hiding this comment.
You can also use lib/eigenlayer-contracts/src/test/mocks/MockAVSRegistrar.sol which is the one used by eigen to mock an avs
src/StakingNode.sol
Outdated
| delegatedTo = stakingNodesManager.delegationManager().delegatedTo(address(this)); | ||
| } | ||
|
|
||
| function initializeV4() external onlyStakingNodesManager reinitializer(4) { |
There was a problem hiding this comment.
If it is not already initialized in holesky, this could be done in the initializeV3
| bytes32 withdrawalRoot = delegationManager.calculateWithdrawalRoot(withdrawal); | ||
| uint256 withdrawableSharesForWithdrawalRootValue = withdrawableSharesForWithdrawalRoot[withdrawalRoot]; | ||
|
|
||
| if (withdrawableSharesForWithdrawalRootValue != 0) { |
There was a problem hiding this comment.
withdrawableSharesForWithdrawalRootValue could be 0 after an operator was fully slashed.
I don't know what happens with withdrawals that are fully slashed. (If they revert on Eigen or not).
But if they don't revert and this goes through the else condition. It might have accounting issues as queuedShares is decreased by scaledShares when it should be 0.
There was a problem hiding this comment.
updated code by considering queuedShares and legacyQueuedShares as separate entity and not mixing accounting
No description provided.