Skip to content

Commit

Permalink
Fix: Deprecated artifacts follow up (aws-observability#327)
Browse files Browse the repository at this point in the history
*Issue #, if available:*
The previous fix did not work because `download-artifacts@v3` is also
deprecated and must be updated.
```
Error: This request has been automatically failed because it uses a deprecated version of `actions/download-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
```

Previous fix:
aws-observability#326

*Description of changes:*
- Updating `download-artifacts@v3` to `v4`.
- Also fixing syntax error for name pattern.


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
  • Loading branch information
yiyuan-he authored Feb 12, 2025
1 parent 865f930 commit c5cad2e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/application-signals-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
role-to-assume: arn:aws:iam::${{ secrets.APPLICATION_SIGNALS_E2E_TEST_ACCOUNT_ID }}:role/${{ secrets.APPLICATION_SIGNALS_E2E_TEST_ROLE_NAME }}
aws-region: us-east-1

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ${{ inputs.staging-wheel-name }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-lambda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ jobs:
- name: download layerARNs
uses: actions/download-artifact@v4
with:
name: ${{ env.LAYER_NAME }}-*
pattern: ${{ env.LAYER_NAME }}-*
path: ${{ env.LAYER_NAME }}
merge-multiple: true
- name: show layerARNs
Expand Down

0 comments on commit c5cad2e

Please sign in to comment.