Support Reverse Proxy and SSL Protocol Detection#59
Open
alcayaga wants to merge 1 commit into
Open
Conversation
- Add configurable 'host' and 'port' to default_config.json - Dynamically detect Host and X-Forwarded-Proto headers for URL construction - Refactor configuration management to use a central CONFIG object - Remove hardcoded 127.0.0.1 binding to allow external access when configured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
Summary
Adds support for running the local audio server behind a reverse proxy, specifically addressing issues with hardcoded binding and static URL generation in responses.
Changes
127.0.0.1 to 0.0.0.0 for external access while keeping the secure default for most users.
Motivation
Previously, the server was hardcoded to bind to 127.0.0.1, and all audio URLs returned to Yomitan were hardcoded to http://127.0.0.1:5050. This made it impossible to use the server over a network or behind a proxy with SSL, as the client would receive unreachable local links.
How to Test
curl -H "Host: my-proxy.net" -H "X-Forwarded-Proto: https" "http://localhost:5050/?term=読む"