Skip to content

Commit

Permalink
Update pkg/document/crdt/rht.go
Browse files Browse the repository at this point in the history
  • Loading branch information
@hackerwins
hackerwins authored Jan 9, 2024
1 parent ff391e9 commit b12d3d2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/document/crdt/rht.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ func (rht *RHT) Remove(k string, executedAt *time.Ticket) string {
if !alreadyRemoved {
rht.numberOfRemovedElement++
}
// node is removed if and only if updatedAt = removedAt
newNode := newRHTNode(k, node.val, executedAt, true)
rht.nodeMapByKey[k] = newNode

Expand Down

1 comment on commit b12d3d2

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go Benchmark

Benchmark suite Current: b12d3d2 Previous: 50b3c50 Ratio
BenchmarkDocument/constructor_test - ns/op 1338 ns/op 1542 ns/op 0.87
BenchmarkDocument/constructor_test - B/op 1208 B/op 1208 B/op 1
BenchmarkDocument/constructor_test - allocs/op 20 allocs/op 20 allocs/op 1
BenchmarkDocument/status_test - ns/op 771.4 ns/op 780 ns/op 0.99
BenchmarkDocument/status_test - B/op 1176 B/op 1176 B/op 1
BenchmarkDocument/status_test - allocs/op 18 allocs/op 18 allocs/op 1
BenchmarkDocument/equals_test - ns/op 7064 ns/op 7138 ns/op 0.99
BenchmarkDocument/equals_test - B/op 6913 B/op 6913 B/op 1
BenchmarkDocument/equals_test - allocs/op 120 allocs/op 120 allocs/op 1
BenchmarkDocument/nested_update_test - ns/op 16046 ns/op 16248 ns/op 0.99
BenchmarkDocument/nested_update_test - B/op 11962 B/op 11963 B/op 1.00
BenchmarkDocument/nested_update_test - allocs/op 254 allocs/op 254 allocs/op 1
BenchmarkDocument/delete_test - ns/op 22263 ns/op 22078 ns/op 1.01
BenchmarkDocument/delete_test - B/op 15188 B/op 15188 B/op 1
BenchmarkDocument/delete_test - allocs/op 333 allocs/op 333 allocs/op 1
BenchmarkDocument/object_test - ns/op 9364 ns/op 8387 ns/op 1.12
BenchmarkDocument/object_test - B/op 6721 B/op 6721 B/op 1
BenchmarkDocument/object_test - allocs/op 116 allocs/op 116 allocs/op 1
BenchmarkDocument/array_test - ns/op 28403 ns/op 28691 ns/op 0.99
BenchmarkDocument/array_test - B/op 11819 B/op 11819 B/op 1
BenchmarkDocument/array_test - allocs/op 270 allocs/op 270 allocs/op 1
BenchmarkDocument/text_test - ns/op 30387 ns/op 31234 ns/op 0.97
BenchmarkDocument/text_test - B/op 14884 B/op 15412 B/op 0.97
BenchmarkDocument/text_test - allocs/op 468 allocs/op 479 allocs/op 0.98
BenchmarkDocument/text_composition_test - ns/op 28630 ns/op 28838 ns/op 0.99
BenchmarkDocument/text_composition_test - B/op 18396 B/op 18590 B/op 0.99
BenchmarkDocument/text_composition_test - allocs/op 477 allocs/op 481 allocs/op 0.99
BenchmarkDocument/rich_text_test - ns/op 79692 ns/op 84725 ns/op 0.94
BenchmarkDocument/rich_text_test - B/op 38644 B/op 47959 B/op 0.81
BenchmarkDocument/rich_text_test - allocs/op 1147 allocs/op 1216 allocs/op 0.94
BenchmarkDocument/counter_test - ns/op 16897 ns/op 16633 ns/op 1.02
BenchmarkDocument/counter_test - B/op 10210 B/op 10210 B/op 1
BenchmarkDocument/counter_test - allocs/op 236 allocs/op 236 allocs/op 1
BenchmarkDocument/text_edit_gc_100 - ns/op 2876574 ns/op 2896824 ns/op 0.99
BenchmarkDocument/text_edit_gc_100 - B/op 1658791 B/op 1658595 B/op 1.00
BenchmarkDocument/text_edit_gc_100 - allocs/op 17093 allocs/op 17092 allocs/op 1.00
BenchmarkDocument/text_edit_gc_1000 - ns/op 229692959 ns/op 232593749 ns/op 0.99
BenchmarkDocument/text_edit_gc_1000 - B/op 144402608 B/op 144379059 B/op 1.00
BenchmarkDocument/text_edit_gc_1000 - allocs/op 201037 allocs/op 200906 allocs/op 1.00
BenchmarkDocument/text_split_gc_100 - ns/op 3375780 ns/op 3420377 ns/op 0.99
BenchmarkDocument/text_split_gc_100 - B/op 2316690 B/op 2316994 B/op 1.00
BenchmarkDocument/text_split_gc_100 - allocs/op 16194 allocs/op 16196 allocs/op 1.00
BenchmarkDocument/text_split_gc_1000 - ns/op 287733590 ns/op 291333302 ns/op 0.99
BenchmarkDocument/text_split_gc_1000 - B/op 228908672 B/op 228919328 B/op 1.00
BenchmarkDocument/text_split_gc_1000 - allocs/op 203877 allocs/op 203934 allocs/op 1.00
BenchmarkDocument/text_delete_all_10000 - ns/op 10550528 ns/op 11818492 ns/op 0.89
BenchmarkDocument/text_delete_all_10000 - B/op 5810399 B/op 5810678 B/op 1.00
BenchmarkDocument/text_delete_all_10000 - allocs/op 40674 allocs/op 40675 allocs/op 1.00
BenchmarkDocument/text_delete_all_100000 - ns/op 185672565 ns/op 201368223 ns/op 0.92
BenchmarkDocument/text_delete_all_100000 - B/op 81901440 B/op 81900570 B/op 1.00
BenchmarkDocument/text_delete_all_100000 - allocs/op 411611 allocs/op 411626 allocs/op 1.00
BenchmarkDocument/text_100 - ns/op 222368 ns/op 220270 ns/op 1.01
BenchmarkDocument/text_100 - B/op 120105 B/op 120107 B/op 1.00
BenchmarkDocument/text_100 - allocs/op 5080 allocs/op 5080 allocs/op 1
BenchmarkDocument/text_1000 - ns/op 2382766 ns/op 2429840 ns/op 0.98
BenchmarkDocument/text_1000 - B/op 1169093 B/op 1169078 B/op 1.00
BenchmarkDocument/text_1000 - allocs/op 50084 allocs/op 50084 allocs/op 1
BenchmarkDocument/array_1000 - ns/op 1176246 ns/op 1191138 ns/op 0.99
BenchmarkDocument/array_1000 - B/op 1091256 B/op 1091341 B/op 1.00
BenchmarkDocument/array_1000 - allocs/op 11825 allocs/op 11826 allocs/op 1.00
BenchmarkDocument/array_10000 - ns/op 12925750 ns/op 13214012 ns/op 0.98
BenchmarkDocument/array_10000 - B/op 9800523 B/op 9800667 B/op 1.00
BenchmarkDocument/array_10000 - allocs/op 120293 allocs/op 120294 allocs/op 1.00
BenchmarkDocument/array_gc_100 - ns/op 142540 ns/op 144166 ns/op 0.99
BenchmarkDocument/array_gc_100 - B/op 132486 B/op 132489 B/op 1.00
BenchmarkDocument/array_gc_100 - allocs/op 1248 allocs/op 1248 allocs/op 1
BenchmarkDocument/array_gc_1000 - ns/op 1351107 ns/op 1375392 ns/op 0.98
BenchmarkDocument/array_gc_1000 - B/op 1158974 B/op 1158914 B/op 1.00
BenchmarkDocument/array_gc_1000 - allocs/op 12865 allocs/op 12864 allocs/op 1.00
BenchmarkDocument/counter_1000 - ns/op 198608 ns/op 198354 ns/op 1.00
BenchmarkDocument/counter_1000 - B/op 192853 B/op 192853 B/op 1
BenchmarkDocument/counter_1000 - allocs/op 5765 allocs/op 5765 allocs/op 1
BenchmarkDocument/counter_10000 - ns/op 2159319 ns/op 2157794 ns/op 1.00
BenchmarkDocument/counter_10000 - B/op 2087767 B/op 2087766 B/op 1.00
BenchmarkDocument/counter_10000 - allocs/op 59772 allocs/op 59772 allocs/op 1
BenchmarkDocument/object_1000 - ns/op 1326274 ns/op 1354096 ns/op 0.98
BenchmarkDocument/object_1000 - B/op 1427980 B/op 1428036 B/op 1.00
BenchmarkDocument/object_1000 - allocs/op 9845 allocs/op 9845 allocs/op 1
BenchmarkDocument/object_10000 - ns/op 14711837 ns/op 15028111 ns/op 0.98
BenchmarkDocument/object_10000 - B/op 12167381 B/op 12166744 B/op 1.00
BenchmarkDocument/object_10000 - allocs/op 100562 allocs/op 100559 allocs/op 1.00
BenchmarkDocument/tree_100 - ns/op 1032273 ns/op 1049112 ns/op 0.98
BenchmarkDocument/tree_100 - B/op 943674 B/op 943678 B/op 1.00
BenchmarkDocument/tree_100 - allocs/op 6099 allocs/op 6099 allocs/op 1
BenchmarkDocument/tree_1000 - ns/op 73631129 ns/op 79782715 ns/op 0.92
BenchmarkDocument/tree_1000 - B/op 86460210 B/op 86460627 B/op 1.00
BenchmarkDocument/tree_1000 - allocs/op 60112 allocs/op 60114 allocs/op 1.00
BenchmarkDocument/tree_10000 - ns/op 9316456528 ns/op 9957562898 ns/op 0.94
BenchmarkDocument/tree_10000 - B/op 8580990888 B/op 8580990424 B/op 1.00
BenchmarkDocument/tree_10000 - allocs/op 600226 allocs/op 600232 allocs/op 1.00
BenchmarkDocument/tree_delete_all_1000 - ns/op 72077165 ns/op 77379744 ns/op 0.93
BenchmarkDocument/tree_delete_all_1000 - B/op 86990646 B/op 86990891 B/op 1.00
BenchmarkDocument/tree_delete_all_1000 - allocs/op 67751 allocs/op 67751 allocs/op 1
BenchmarkDocument/tree_edit_gc_100 - ns/op 3633333 ns/op 3743356 ns/op 0.97
BenchmarkDocument/tree_edit_gc_100 - B/op 4121028 B/op 4120983 B/op 1.00
BenchmarkDocument/tree_edit_gc_100 - allocs/op 14356 allocs/op 14356 allocs/op 1
BenchmarkDocument/tree_edit_gc_1000 - ns/op 295473166 ns/op 311312288 ns/op 0.95
BenchmarkDocument/tree_edit_gc_1000 - B/op 383465056 B/op 383465558 B/op 1.00
BenchmarkDocument/tree_edit_gc_1000 - allocs/op 145397 allocs/op 145406 allocs/op 1.00
BenchmarkDocument/tree_split_gc_100 - ns/op 2448548 ns/op 2564917 ns/op 0.95
BenchmarkDocument/tree_split_gc_100 - B/op 2386848 B/op 2386900 B/op 1.00
BenchmarkDocument/tree_split_gc_100 - allocs/op 10341 allocs/op 10341 allocs/op 1
BenchmarkDocument/tree_split_gc_1000 - ns/op 180463375 ns/op 194397785 ns/op 0.93
BenchmarkDocument/tree_split_gc_1000 - B/op 221991165 B/op 221990026 B/op 1.00
BenchmarkDocument/tree_split_gc_1000 - allocs/op 112256 allocs/op 112248 allocs/op 1.00
BenchmarkRPC/client_to_server - ns/op 358330199 ns/op 364396329 ns/op 0.98
BenchmarkRPC/client_to_server - B/op 17803698 B/op 18067424 B/op 0.99
BenchmarkRPC/client_to_server - allocs/op 166906 allocs/op 165863 allocs/op 1.01
BenchmarkRPC/client_to_client_via_server - ns/op 604429284 ns/op 625660123 ns/op 0.97
BenchmarkRPC/client_to_client_via_server - B/op 31594104 B/op 32815272 B/op 0.96
BenchmarkRPC/client_to_client_via_server - allocs/op 311896 allocs/op 310207 allocs/op 1.01
BenchmarkRPC/attach_large_document - ns/op 1225770345 ns/op 1355198048 ns/op 0.90
BenchmarkRPC/attach_large_document - B/op 1879534736 B/op 1868233624 B/op 1.01
BenchmarkRPC/attach_large_document - allocs/op 7553 allocs/op 7466 allocs/op 1.01
BenchmarkRPC/adminCli_to_server - ns/op 537302964 ns/op 549909416 ns/op 0.98
BenchmarkRPC/adminCli_to_server - B/op 35991048 B/op 36780108 B/op 0.98
BenchmarkRPC/adminCli_to_server - allocs/op 289652 allocs/op 288662 allocs/op 1.00
BenchmarkLocker - ns/op 64.4 ns/op 65.86 ns/op 0.98
BenchmarkLocker - B/op 16 B/op 16 B/op 1
BenchmarkLocker - allocs/op 1 allocs/op 1 allocs/op 1
BenchmarkLockerParallel - ns/op 38.05 ns/op 38.59 ns/op 0.99
BenchmarkLockerParallel - B/op 0 B/op 0 B/op NaN
BenchmarkLockerParallel - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkLockerMoreKeys - ns/op 144 ns/op 148.9 ns/op 0.97
BenchmarkLockerMoreKeys - B/op 15 B/op 15 B/op 1
BenchmarkLockerMoreKeys - allocs/op 0 allocs/op 0 allocs/op NaN
BenchmarkChange/Push_10_Changes - ns/op 3756246 ns/op 3838436 ns/op 0.98
BenchmarkChange/Push_10_Changes - B/op 126270 B/op 125677 B/op 1.00
BenchmarkChange/Push_10_Changes - allocs/op 1253 allocs/op 1254 allocs/op 1.00
BenchmarkChange/Push_100_Changes - ns/op 14006996 ns/op 14440415 ns/op 0.97
BenchmarkChange/Push_100_Changes - B/op 650592 B/op 647975 B/op 1.00
BenchmarkChange/Push_100_Changes - allocs/op 6541 allocs/op 6540 allocs/op 1.00
BenchmarkChange/Push_1000_Changes - ns/op 112492717 ns/op 115497921 ns/op 0.97
BenchmarkChange/Push_1000_Changes - B/op 6094921 B/op 6151829 B/op 0.99
BenchmarkChange/Push_1000_Changes - allocs/op 62161 allocs/op 62159 allocs/op 1.00
BenchmarkChange/Pull_10_Changes - ns/op 2827839 ns/op 2909758 ns/op 0.97
BenchmarkChange/Pull_10_Changes - B/op 100760 B/op 100076 B/op 1.01
BenchmarkChange/Pull_10_Changes - allocs/op 952 allocs/op 952 allocs/op 1
BenchmarkChange/Pull_100_Changes - ns/op 4267546 ns/op 4414877 ns/op 0.97
BenchmarkChange/Pull_100_Changes - B/op 258079 B/op 256121 B/op 1.01
BenchmarkChange/Pull_100_Changes - allocs/op 3154 allocs/op 3154 allocs/op 1
BenchmarkChange/Pull_1000_Changes - ns/op 8296485 ns/op 8566513 ns/op 0.97
BenchmarkChange/Pull_1000_Changes - B/op 1397707 B/op 1392837 B/op 1.00
BenchmarkChange/Pull_1000_Changes - allocs/op 26874 allocs/op 26865 allocs/op 1.00
BenchmarkSnapshot/Push_3KB_snapshot - ns/op 16585464 ns/op 17384863 ns/op 0.95
BenchmarkSnapshot/Push_3KB_snapshot - B/op 796981 B/op 802328 B/op 0.99
BenchmarkSnapshot/Push_3KB_snapshot - allocs/op 6539 allocs/op 6549 allocs/op 1.00
BenchmarkSnapshot/Push_30KB_snapshot - ns/op 116284290 ns/op 118971166 ns/op 0.98
BenchmarkSnapshot/Push_30KB_snapshot - B/op 6273528 B/op 6156721 B/op 1.02
BenchmarkSnapshot/Push_30KB_snapshot - allocs/op 62161 allocs/op 62158 allocs/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - ns/op 6497137 ns/op 6602183 ns/op 0.98
BenchmarkSnapshot/Pull_3KB_snapshot - B/op 906056 B/op 902235 B/op 1.00
BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op 14883 allocs/op 14878 allocs/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - ns/op 14656932 ns/op 14754933 ns/op 0.99
BenchmarkSnapshot/Pull_30KB_snapshot - B/op 6983710 B/op 6981411 B/op 1.00
BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op 144139 allocs/op 144131 allocs/op 1.00
BenchmarkSync/memory_sync_10_test - ns/op 6792 ns/op 6984 ns/op 0.97
BenchmarkSync/memory_sync_10_test - B/op 1286 B/op 1286 B/op 1
BenchmarkSync/memory_sync_10_test - allocs/op 38 allocs/op 38 allocs/op 1
BenchmarkSync/memory_sync_100_test - ns/op 51338 ns/op 51752 ns/op 0.99
BenchmarkSync/memory_sync_100_test - B/op 8655 B/op 8655 B/op 1
BenchmarkSync/memory_sync_100_test - allocs/op 274 allocs/op 274 allocs/op 1
BenchmarkSync/memory_sync_1000_test - ns/op 572623 ns/op 593943 ns/op 0.96
BenchmarkSync/memory_sync_1000_test - B/op 75288 B/op 74410 B/op 1.01
BenchmarkSync/memory_sync_1000_test - allocs/op 2169 allocs/op 2113 allocs/op 1.03
BenchmarkSync/memory_sync_10000_test - ns/op 7079170 ns/op 7699568 ns/op 0.92
BenchmarkSync/memory_sync_10000_test - B/op 763568 B/op 761656 B/op 1.00
BenchmarkSync/memory_sync_10000_test - allocs/op 20540 allocs/op 20495 allocs/op 1.00
BenchmarkTextEditing - ns/op 18626617892 ns/op 19296651559 ns/op 0.97
BenchmarkTextEditing - B/op 9041934512 B/op 9041594456 B/op 1.00
BenchmarkTextEditing - allocs/op 19922366 allocs/op 19920775 allocs/op 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.