Add features structure type #184

musaprg · 2024-07-07T04:22:03Z

This PR adds Features based on the specs-go implementation in the runtime spec. That's supposed to be used by features subcommand of runtime and will replace the local type defined in the runtime such as youki.

TODO

Add tests for required fields.
Add tests for all fields including optional ones

musaprg · 2024-07-30T14:25:45Z

The CI has failed due to missing labels, and I don't have permission to add them. Could anyone look into it? Thanks.

utam0k

Thanks! Let's consider reusing the already-defined structures.

utam0k · 2024-07-31T11:51:09Z

src/runtime/features.rs

+use getset::{Getters, MutGetters, Setters};
+use serde::{Deserialize, Serialize};
+
+/// Features Structure that represents supported features of the runtime.


Suggested change

/// Features Structure that represents supported features of the runtime.

/// Features represents supported features of the runtime.

fixed in bb504b4

utam0k · 2024-07-31T11:59:30Z

src/runtime/features.rs

+pub struct Linux {
+    /// The list of the recognized namespaces, e.g., "mount".
+    /// "None" means "unknown", not "no support for any namespace".
+    namespaces: Option<Vec<String>>,


Can we use LinuxNamespaceType?
https://github.com/musaprg/oci-spec-rs/blob/6ecc08b6f348c28cd769f3264356f08f95994d77/src/runtime/linux.rs#L805-L806

fixed to reuse existing types in e247914

utam0k · 2024-07-31T12:00:58Z

src/runtime/features.rs

+    enabled: Option<bool>,
+    actions: Option<Vec<String>>,
+    operators: Option<Vec<String>>,
+    archs: Option<Vec<String>>,


Can we use it?
https://github.com/musaprg/oci-spec-rs/blob/6ecc08b6f348c28cd769f3264356f08f95994d77/src/runtime/linux.rs#L1093

I've added the missing ScmpArchRiscv64 to the Arch enum.
You can check the value of SCMP_ARCH_RISCV64 (originally AUDIT_ARCH_RISCV64) from the libseccomp source, or calculated values are available on the golang.org/x/sys/unix package.

2325f34

fixed to reuse existing types in e247914

utam0k · 2024-07-31T12:02:19Z

src/runtime/features.rs

+#[serde(rename_all = "camelCase")]
+pub struct Seccomp {
+    enabled: Option<bool>,
+    actions: Option<Vec<String>>,


https://github.com/musaprg/oci-spec-rs/blob/6ecc08b6f348c28cd769f3264356f08f95994d77/src/runtime/linux.rs#L1056

I've added ScmpActKillThread into the LinuxSeccompAction enum. It's equivalent to ScmpActKill but needs to be defined explicitly to conform to the spec. I need to implement the From trait for u32 because we cannot define multiple enum items with the same value 0x00000000.

129d82a

fixed to reuse existing types in e247914

utam0k

Thanks! Let's consider reusing the already-defined structures.

musaprg · 2024-08-07T17:09:08Z

src/runtime/linux.rs

@@ -1051,32 +1051,50 @@ pub struct LinuxSeccomp {
 #[derive(Clone, Copy, Debug, Deserialize, Eq, PartialEq, Serialize, StrumDisplay, EnumString)]
 #[strum(serialize_all = "SCREAMING_SNAKE_CASE")]
 #[serde(rename_all = "SCREAMING_SNAKE_CASE")]
-#[repr(u32)]


I'm not confident whether this line is safe to delete.

utam0k · 2024-08-09T12:53:56Z

Hi, thanks for your update. Since I'm on vacation this week, I'll revisit here after next week.

@saschagrunert If possible, can you take a look at this🙏

musaprg · 2024-08-10T15:21:12Z

The CI (ci / lint-clippy) failed, but it doesn't seem relevant to this PR. I checked and the error also occurred on the main branch, so I submitted another PR to fix the linter error. Could you also check it?

#195

utam0k · 2024-08-14T12:19:01Z

@musaprg Can you rebase this PR from the main branch to pass the CI?

This PR adds Features based on the specs-go implementation in the runtime spec. That's supposed to be used by features subcommand of runtime and will replace the local type defined in the runtime such as youki. Signed-off-by: Kotaro Inoue <[email protected]>

Signed-off-by: Kotaro Inoue <[email protected]>

musaprg · 2024-08-14T13:16:51Z

@utam0k Hi, I've rebased the branch with the current main branch. Could you check it again? Thanks.

musaprg marked this pull request as ready for review July 7, 2024 04:40

musaprg marked this pull request as draft July 7, 2024 04:46

musaprg force-pushed the support-features-structure branch 2 times, most recently from bb4c4f7 to 6f3e7e0 Compare July 29, 2024 17:12

musaprg marked this pull request as ready for review July 29, 2024 17:12

musaprg force-pushed the support-features-structure branch from 6f3e7e0 to 6ecc08b Compare July 30, 2024 14:48

utam0k added the kind/runtime label Jul 31, 2024

utam0k approved these changes Jul 31, 2024

View reviewed changes

utam0k self-requested a review July 31, 2024 12:03

utam0k requested changes Jul 31, 2024

View reviewed changes

musaprg commented Aug 7, 2024

View reviewed changes

saschagrunert approved these changes Aug 14, 2024

View reviewed changes

musaprg requested a review from utam0k August 14, 2024 08:59

musaprg added 6 commits August 14, 2024 22:15

Add features structure type

05657d0

This PR adds Features based on the specs-go implementation in the runtime spec. That's supposed to be used by features subcommand of runtime and will replace the local type defined in the runtime such as youki. Signed-off-by: Kotaro Inoue <[email protected]>

fixup! Add features structure type

d436c47

Signed-off-by: Kotaro Inoue <[email protected]>

fixup! Add features structure type

1972d31

Signed-off-by: Kotaro Inoue <[email protected]>

fixup! Add features structure type

4f72249

Signed-off-by: Kotaro Inoue <[email protected]>

fixup! Add features structure type

c2d90dd

Signed-off-by: Kotaro Inoue <[email protected]>

fixup! Add features structure type

bda7b0c

Signed-off-by: Kotaro Inoue <[email protected]>

musaprg force-pushed the support-features-structure branch from e247914 to bda7b0c Compare August 14, 2024 13:15

utam0k approved these changes Aug 14, 2024

View reviewed changes

utam0k merged commit cf455b4 into youki-dev:main Aug 14, 2024
14 checks passed

musaprg deleted the support-features-structure branch August 14, 2024 15:21

musaprg mentioned this pull request Aug 17, 2024

Add Builder for features structures #199

Merged

musaprg mentioned this pull request Sep 11, 2024

Release v0.7.0 #210

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add features structure type #184

Add features structure type #184

musaprg commented Jul 7, 2024 •

edited

Loading

musaprg commented Jul 30, 2024

utam0k left a comment

utam0k Jul 31, 2024

musaprg Aug 7, 2024

utam0k Jul 31, 2024

musaprg Aug 7, 2024

utam0k Jul 31, 2024

musaprg Aug 7, 2024 •

edited

Loading

musaprg Aug 7, 2024

utam0k Jul 31, 2024

musaprg Aug 7, 2024 •

edited

Loading

musaprg Aug 7, 2024

utam0k left a comment

musaprg Aug 7, 2024

utam0k commented Aug 9, 2024

musaprg commented Aug 10, 2024

utam0k commented Aug 14, 2024 •

edited

Loading

musaprg commented Aug 14, 2024 •

edited

Loading

	/// Features Structure that represents supported features of the runtime.
	/// Features represents supported features of the runtime.

Add features structure type #184

Add features structure type #184

Conversation

musaprg commented Jul 7, 2024 • edited Loading

musaprg commented Jul 30, 2024

utam0k left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musaprg Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musaprg Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

utam0k left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

utam0k commented Aug 9, 2024

musaprg commented Aug 10, 2024

utam0k commented Aug 14, 2024 • edited Loading

musaprg commented Aug 14, 2024 • edited Loading

musaprg commented Jul 7, 2024 •

edited

Loading

musaprg Aug 7, 2024 •

edited

Loading

musaprg Aug 7, 2024 •

edited

Loading

utam0k commented Aug 14, 2024 •

edited

Loading

musaprg commented Aug 14, 2024 •

edited

Loading