vm: replace jump table with switch #479
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple years ago the go compiler finally implemented jumptables for switch:
https://go-review.googlesource.com/c/go/+/357330
In order to avoid function call overhead of
evalInstruction
, a mainLoop/mainLoopWithContext are combined for inliningBenchmarks done with: AMD Ryzen 7 7840U w/ Radeon 780M Graphics
before:
with only switch:
with combined main loops:
with evalInstruction inlined & lifting reg assignment out of loop: