-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build #7
Docker build #7
Conversation
The output from Docker build - binary module ( |
Good point thank you... Will provide builds for each supported (at least
for zabbix-docker ) os.
Jan Garaj <[email protected]> schrieb am Di., 4. Sep. 2018, 16:45:
The output from Docker build - binary module (.so file) will be working
only in Debian Stretch OS + in theory only for Zabbix major version, which
has been used for the compilation -> it will be confusing for non Debian
Strech users, when output from this Docker build will be broken for them.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbq-ANecJInS_0QrzQPXYmbS6DULHSEks5uXpIWgaJpZM4WZFXP>
.
--
Live long and prosper 🖖
Markus
|
Good luck with Alpine version 😎. You can use https://github.com/monitoringartist/zabbix-docker-monitoring/tree/master/dockerfiles as an inspiration. |
Yes thought about those too. If one is problematic I would first publish
those working. Documenting it in Readme should clarify all.
If it's problematic for a distribution, it would be questionable if there
are already builds for that out there.
Also will provide python 3 only as newer projects shouldn't use 2 anyways.
Jan Garaj <[email protected]> schrieb am Di., 4. Sep. 2018, 17:38:
Good luck with Alpine version 😎. You can use
https://github.com/monitoringartist/zabbix-docker-monitoring/tree/master/dockerfiles
as an inspiration.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbq-FD2sm5auFAavjwT6Y7PIQ-WgorZks5uXp6CgaJpZM4WZFXP>
.
--
Live long and prosper 🖖
Markus
|
Welcome to our personal nightmare! Supporting various linux distros 😂. Just a note about Python 2, you'll find many organizations will "never" move to Python 3. Also many distros still ship Python 2 as default Python. If I recall, I never got this library building for Python 3... |
You're right of course on both things. But then I think the additional
option for build with docker is just that, an option. Those who are on
distris not covered by official zabbix-docker or are on Python 2 off course
still could and should use the default build routine.
If come along your project several times but now I have some use cases. I
just wanted to ease my build pain and thought I would ease those of others
too. I think often projects aren't used because their source build
complications.
Will provide update the Readme to point out current limitations. Hopefully
you can accept PR then. Will provide further PRs on weekends then.
Thought as pointed out it would be cool if you create an automated build on
docker hub to. If you don't want to do that I could just fork the project
and will reference by my username if it's ok. Of course by linking to your
original sources!
…--
Live long and prosper 🖖
Markus
|
This is sounds good to me! Thank you for contributing. I've added you as a collaborator, so you should be able to publish on docker hub, under whatever name you like. Please still submit PRs rather than committing directly, so we have some level of peer review and quality control. |
to prepare for additional images
Added additional information for first image and pointing out current limitation on python 3.7 and Debian Stretch. Also moved the image to an dedicated folder for comming auto builds. Would be great if we can merge this PR so i can go ahead with other images and set up auto builds. |
Fixes #6 |
I found some troubles with 3.4.14 |
A docker image (Dockerfile) for providing an containerized build environment to build the module. Outputs the build modules to ./build folder.
Would be great, if you could also enable an autobuild repository on hub.docker.com?