Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build #7

Closed
wants to merge 7 commits into from
Closed

Docker build #7

wants to merge 7 commits into from

Conversation

rockaut
Copy link

@rockaut rockaut commented Sep 4, 2018

A docker image (Dockerfile) for providing an containerized build environment to build the module. Outputs the build modules to ./build folder.

Would be great, if you could also enable an autobuild repository on hub.docker.com?

@jangaraj
Copy link
Collaborator

jangaraj commented Sep 4, 2018

The output from Docker build - binary module (.so file) will be working only in Debian Stretch OS + in theory only for Zabbix major version, which has been used for the compilation -> it will be confusing for non Debian Strech users, when output from this Docker build will be broken for them.

@rockaut
Copy link
Author

rockaut commented Sep 4, 2018 via email

@jangaraj
Copy link
Collaborator

jangaraj commented Sep 4, 2018

Good luck with Alpine version 😎. You can use https://github.com/monitoringartist/zabbix-docker-monitoring/tree/master/dockerfiles as an inspiration.

@rockaut
Copy link
Author

rockaut commented Sep 4, 2018 via email

@cavaliercoder
Copy link
Collaborator

Welcome to our personal nightmare! Supporting various linux distros 😂.

Just a note about Python 2, you'll find many organizations will "never" move to Python 3. Also many distros still ship Python 2 as default Python.

If I recall, I never got this library building for Python 3...

@rockaut
Copy link
Author

rockaut commented Sep 4, 2018 via email

@cavaliercoder
Copy link
Collaborator

This is sounds good to me! Thank you for contributing. I've added you as a collaborator, so you should be able to publish on docker hub, under whatever name you like. Please still submit PRs rather than committing directly, so we have some level of peer review and quality control.

@rockaut
Copy link
Author

rockaut commented Sep 11, 2018

Added additional information for first image and pointing out current limitation on python 3.7 and Debian Stretch. Also moved the image to an dedicated folder for comming auto builds.

Would be great if we can merge this PR so i can go ahead with other images and set up auto builds.

@rockaut
Copy link
Author

rockaut commented Sep 11, 2018

Fixes #6

@rockaut rockaut closed this Sep 28, 2018
@rockaut
Copy link
Author

rockaut commented Sep 28, 2018

I found some troubles with 3.4.14
Will update and redo PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants