Skip to content

fix index in TestGenerateSpiloPodEnvVars #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix index in TestGenerateSpiloPodEnvVars #1084

merged 1 commit into from
Jul 30, 2020

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Jul 30, 2020

PR #946 changed the order of Pod env variables to allow overwriting by additional variables coming from ConfigMap or Secret. Thus the DCS_ENABLE_KUBERNETES_API or ETCD_HOST variables now come before the additional variables

@FxKu FxKu changed the title fix index in TestGenerateSpiloPodEnvVarswq fix index in TestGenerateSpiloPodEnvVars Jul 30, 2020
@Jan-M
Copy link
Member

Jan-M commented Jul 30, 2020

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Jul 30, 2020

👍

@FxKu FxKu merged commit 3bee590 into master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaczi avaczi Awaiting requested review from avaczi

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@erthalion erthalion Awaiting requested review from erthalion

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@RafiaSabih RafiaSabih Awaiting requested review from RafiaSabih

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FxKu @Jan-M