Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gpu): initialize some arrays to 0 #1556

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@bbarbakadze
Copy link
Contributor

We don't need all of those memsets but for clarity and for code to be more robust it is good to have.
It couldn't affect benchmarks, so it's good to go.

@agnesLeroy agnesLeroy merged commit 4823b8a into main Sep 20, 2024
91 checks passed
@agnesLeroy agnesLeroy deleted the al/initialize_arrays branch September 20, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants