chore(gpu): improve compression tests #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
2 times, most recently
from
199123e to
1308197
Compare
agnesLeroy
approved these changes
Sep 20, 2024
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
1308197 to
852dbea
Compare
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
4 times, most recently
from
c607a65 to
bc516b6
Compare
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
bc516b6 to
e4f76fd
Compare
- the logic was wrong when the integer is split in multiple GLWEs - now the test pseudo-randomly mix unsigned, signed, and booleans
pdroalves
force-pushed
the
pa/chore/improve_compression_test
branch
from
e4f76fd to
1be155b
Compare
agnesLeroy
reviewed
Sep 26, 2024
| @@ -141,7 +141,7 @@ extern "C" { | |||
| gpu_count: u32, | |||
| lwe_array_out: *mut c_void, | |||
| glwe_in: *const c_void, | |||
| indexes_array: *const c_void, | |||
| indexes_array: *const u32, | |||
There was a problem hiding this comment.
I think the c++ entry point should be modified as well if you change this, right now it takes void*. We should always pass u32 for indexes arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/714
PR content/description
Check-list: