chore(zk): add a proof compat test between x86_64 and wasm #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsarlin-zama
force-pushed
the
ns/zk_test_wasm_x86
branch
4 times, most recently
from
3614558 to
1155d9e
Compare
nsarlin-zama
force-pushed
the
ns/zk_test_wasm_x86
branch
from
1155d9e to
2350cc2
Compare
soonum
approved these changes
Nov 5, 2024
nsarlin-zama
force-pushed
the
ns/zk_test_wasm_x86
branch
from
2350cc2 to
1908abe
Compare
soonum
approved these changes
Nov 5, 2024
IceTDrinker
reviewed
Nov 5, 2024
| @@ -7,5 +7,5 @@ | |||
| "test": "node --test --test-reporter=tap" | |||
| }, | |||
| "author": "", | |||
| "license": "ISC" | |||
| "license": "BSD-3-Clause" | |||
There was a problem hiding this comment.
BSD-3-Clause-Clear actually, not the same as the BSD 3 Clause
IceTDrinker
reviewed
Nov 5, 2024
| }, | ||
| "type": "commonjs", | ||
| "author": "", | ||
| "license": "BSD-3-Clause", |
IceTDrinker
reviewed
Nov 5, 2024
| @@ -10,7 +10,7 @@ | |||
| "check-format": "prettier . --check" | |||
| }, | |||
| "author": "", | |||
| "license": "ISC", | |||
| "license": "BSD-3-Clause", | |||
IceTDrinker
reviewed
Nov 5, 2024
Comment on lines
+21
to
+23
| let config = ConfigBuilder::default().build(); | ||
| let client_key = ClientKey::generate(config); | ||
| let pub_key = CompactPublicKey::new(&client_key); |
There was a problem hiding this comment.
that's not the Blockchain config
see the test_proven_compact_list_with_casting
for config
IceTDrinker
reviewed
Nov 5, 2024
Comment on lines
+20
to
+21
|
|
||
| builder.push_u8(0xff); |
IceTDrinker
reviewed
Nov 5, 2024
|
|
||
| const encrypted = builder.build_with_proof_packed( | ||
| publicParams, | ||
| new Uint8Array(), |
There was a problem hiding this comment.
could use a metadata array maybe ?
need the same on the rust side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/810
PR content/description
This PR adds a test that:
This is done to validate proof compatibility between wasm (32b) and x86_64