Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: homogenize conformance parameters #2046

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

nsarlin-zama
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Homogenize the names of the conformance parameters:

  • use the suffix ConformanceParams everywhere
  • use the name of the main type as a prefix except when the parameters are reused from another type

@cla-bot cla-bot bot added the cla-signed label Feb 10, 2025
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/conformance_param_names branch from ae2ad88 to d051be3 Compare February 10, 2025 17:39
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/conformance_param_names branch from d051be3 to d901468 Compare February 17, 2025 10:09
@zama-bot zama-bot removed the approved label Feb 17, 2025
BREAKING CHANGE: renamed some conformance parameters public types
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/conformance_param_names branch from d901468 to 2441526 Compare February 17, 2025 10:22
Copy link
Contributor

@mayeul-zama mayeul-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me as well ! Thanks !

@IceTDrinker
Copy link
Member

looks good to merge

@nsarlin-zama nsarlin-zama merged commit 0809eb9 into main Feb 17, 2025
102 of 105 checks passed
@nsarlin-zama nsarlin-zama deleted the ns/chore/conformance_param_names branch February 17, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants