Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gpu): add some checks on radix sizes, fix shift/rotate #2057

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore(gpu): add some checks on radix sizes, fix shift/rotate #2057

merged 2 commits into from
Feb 13, 2025

Conversation

agnesLeroy
Copy link
Contributor

@agnesLeroy agnesLeroy commented Feb 12, 2025 •
edited
Loading

closes: please link all relevant issues

PR content/description

This PR adds checks on numbers of radix blocks and fixes a bug in shift/rotate.

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Feb 12, 2025
@agnesLeroy agnesLeroy marked this pull request as ready for review February 13, 2025 12:52
@agnesLeroy agnesLeroy changed the title chore(gpu): add some checks on radix sizes for carry propagation chore(gpu): add some checks on radix sizes, fix shift/rotate Feb 13, 2025
@agnesLeroy agnesLeroy merged commit a7c9357 into main Feb 13, 2025
102 of 106 checks passed
@agnesLeroy agnesLeroy deleted the al/add_cuda_size_checks branch February 13, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillermo-oyarzun guillermo-oyarzun guillermo-oyarzun approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @guillermo-oyarzun @zama-bot