Skip to content

HPU backend fixes - #3685

Merged
pgardratzama merged 8 commits into
mainfrom
br/hpu_dev
Jul 2, 2026
Merged

HPU backend fixes #3685
pgardratzama merged 8 commits into
mainfrom
br/hpu_dev

Conversation

@Bapt-Roux

Copy link
Copy Markdown
Contributor

Summary

  • Fix mmap ptr lifetime — replaced explicit munmap call with a Drop trait implementation, ensuring correct memory cleanup via Rust's drop glue
  • Fix HpuDevice init — updated missed function calls left behind from a prior HPU backend refactor
  • Fix DMA queue write guard — now reads and validates the max queue value before attempting to write it, preventing out-of-bounds writes
  • Fix DMA queue PATH — added missing PATH entry required to update DMA queues

Chores

  • Updated psi64.hpu with latest bitstream and firmware from main
  • Extended the HPU bench GitHub workflow to run on a broader set of HPU targets

@Bapt-Roux
Bapt-Roux requested review from a team, SouchonTheo and soonum as code owners July 2, 2026 12:38
@cla-bot cla-bot Bot added the cla-signed label Jul 2, 2026
pgardratzama
pgardratzama previously approved these changes Jul 2, 2026

@pgardratzama pgardratzama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bench from github workflow are running and manual tests look good

…ands should be done without password, fix bench doc issue
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Backward-compat snapshot: everything looks good! No backward-compatibility issues detected.

@pgardratzama
pgardratzama merged commit 4890c9f into main Jul 2, 2026
196 checks passed
@pgardratzama
pgardratzama deleted the br/hpu_dev branch July 2, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants