Skip to content

feat(gpu): add DISPATCH_POLY_SIZE macro to replace manual switch dispatches - #3845

Open
pdroalves wants to merge 1 commit into
pa/fix/static_warningsfrom
pa/chore/avoid_switches
Open

feat(gpu): add DISPATCH_POLY_SIZE macro to replace manual switch dispatches#3845
pdroalves wants to merge 1 commit into
pa/fix/static_warningsfrom
pa/chore/avoid_switches

Conversation

@pdroalves

Copy link
Copy Markdown
Contributor

This PR introduces macros to avoid the long and error prone switch cases we use when Params based on AmortizedDegree or Degree are needed.

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@pdroalves
pdroalves requested a review from a team as a code owner August 19, 2026 19:09
@cla-bot cla-bot Bot added the cla-signed label Aug 19, 2026
@github-actions

Copy link
Copy Markdown

Backward-compat snapshot: everything looks good! No backward-compatibility issues detected.

@github-actions

Copy link
Copy Markdown

Forward Compatibility Matrix

TYPE 1.5.5 loads 1.6.3 data 1.5.5 loads 1.7.0 data 1.6.3 loads 1.7.0 data 1.5.5 loads nightly data 1.6.3 loads nightly data 1.7.0 loads nightly data
CompactPublicKey FAIL: invalid value: integer 1, expected variant index 0 <= i < 1 FAIL: invalid value: integer 1, expected variant index 0 <= i < 1 OK FAIL: invalid value: integer 1, expected variant index 0 <= i < 1 OK OK
CompactPkeCrs OK OK OK OK OK OK
ProvenCompactCiphertextList FAIL: invalid value: integer 1, expected variant index 0 <= i < 1 FAIL: invalid value: integer 1, expected variant index 0 <= i < 1 OK FAIL: invalid value: integer 1, expected variant index 0 <= i < 1 OK OK

@pdroalves
pdroalves force-pushed the pa/fix/static_warnings branch from 3935c79 to f0e8ec5 Compare August 19, 2026 19:30
@pdroalves
pdroalves force-pushed the pa/chore/avoid_switches branch 2 times, most recently from 1ecaebb to 65e5e80 Compare August 19, 2026 20:04
@pdroalves
pdroalves force-pushed the pa/fix/static_warnings branch from f0e8ec5 to 78ab24a Compare August 19, 2026 20:05
@pdroalves
pdroalves force-pushed the pa/chore/avoid_switches branch from 65e5e80 to b347610 Compare August 20, 2026 02:06
@github-actions

Copy link
Copy Markdown

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@pdroalves
pdroalves force-pushed the pa/chore/avoid_switches branch from b347610 to f6acec4 Compare August 20, 2026 02:09
@pdroalves
pdroalves force-pushed the pa/fix/static_warnings branch 2 times, most recently from d36cc09 to ee2d133 Compare August 20, 2026 11:46
@pdroalves
pdroalves force-pushed the pa/chore/avoid_switches branch from f6acec4 to 5552317 Compare August 20, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant