Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Am/fix/0 4 compact #917

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Am/fix/0 4 compact #917

merged 6 commits into from
Feb 28, 2024

Conversation

IceTDrinker
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 26, 2024
@github-actions GitHub Actions
Copy link

@slab-ci cpu_fast_test

@IceTDrinker
Copy link
Member Author

@slab-ci cpu_fast_test

@IceTDrinker
chore(ci): fix test runs by moving panic to its own test file
e2e75a3 
- investigate what goes wrong in the panic hook leading to multiple use of
the same object from the js side
@github-actions GitHub Actions
Copy link

@slab-ci cpu_fast_test

@github-actions GitHub Actions
Copy link

@slab-ci cpu_fast_test

mayeul-zama
mayeul-zama approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@mayeul-zama mayeul-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions GitHub Actions
Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@IceTDrinker
Copy link
Member Author

@slab-ci cpu_integer_test

@IceTDrinker
Copy link
Member Author

sigkill, likely oom...

@tmontaigu @IceTDrinker
chore(integer): use Arc<ServerKey> for executor
f03a2cd 
The goal is to avoid holding the key twice in memory
when both the executor and the test case needs the key
@github-actions GitHub Actions
Copy link

@slab-ci cpu_fast_test

@github-actions github-actions bot removed the approved label Feb 28, 2024
@github-actions GitHub Actions
Copy link

Pull Request has been approved 🎉
Launching full test suite...
@slab-ci cpu_test
@slab-ci cpu_integer_test
@slab-ci cpu_multi_bit_test
@slab-ci cpu_wasm_test
@slab-ci csprng_randomness_testing

@IceTDrinker
Copy link
Member Author

IceTDrinker commented Feb 28, 2024 •
edited
Loading

wasm succeeded but the check run has not been updated, I think we used to encounter such small issues with Slab

Edit: it was a few seconds after I posted that 🙃

https://github.com/zama-ai/tfhe-rs/actions/runs/8078238377

@IceTDrinker IceTDrinker merged commit c0240af into release/0.4.x Feb 28, 2024
20 checks passed
@IceTDrinker IceTDrinker deleted the am/fix/0-4-compact branch February 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayeul-zama mayeul-zama mayeul-zama approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceTDrinker @mayeul-zama @tmontaigu