-
-
Notifications
You must be signed in to change notification settings - Fork 327
(fix): use typesize
on Blosc
codec
#2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good @ilan-gold, we just a release note
Apologies did not mean for you guys to do an immediate review, will keep that in mind next time, this was mostly to remind myself to finish up :) |
no worries, I was trigger-happy here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding a test for this that asserts a certain compressed size, so we can catch regressions in the future? The doctest is a nice way to catch this, but I worry that it might get removed or changed whereas a test is more likely to stay around.
Fixes #2766 and fixes #2171
TODO:
docs/user-guide/*.rst
changes/