Ignore stale children when reconsolidating metadata #2980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when recreating consolidated metadata, when one of the child groups picked up had (stale) consolidated metadata.
In
consolidate_metadata
, we already ignore thegroup.metadata.consolidated_metadata
for the root group. The fix is to also ignore the consolidated metadata for any child nodes loaded by.members()
.For now, I've made this a new public parameter in
.members()
. It might be worth keeping it private (by making a_members_private
method that takes this parameter). I don't immediately see any other use case for this parameter.Closes #2921
TODO:
docs/user-guide/*.rst
changes/