Skip to content

fix:*-like creation routines take kwargs #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Apr 17, 2025

In main, array creation routines that take an existing array, like full_like, zeros_like, etc, don't allow users to override certain array properties (like shape and dtype) via keyword arguments. E.g., full_like(arr, shape=(10,)) will ignore the shape keyword argument and produce an array with the same shape as arr.

This PR makes these array creation routines sensitive to keyword arguments like shape, dtype, chunks, etc.

closes #2989

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 17, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Apr 17, 2025
@d-v-b d-v-b requested a review from jhamman April 20, 2025 19:34
@d-v-b
Copy link
Contributor Author

d-v-b commented Apr 20, 2025

requesting review from @jhamman since I think you touched this code most recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Function zeros_like ignores overrides in keyword arguments (e.g. chunks, dtype).
1 participant