Fix order handling #3112
Draft
Fix order handling #3112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
reviewed
Jun 3, 2025
dstansby
commented
Jun 3, 2025
| @staticmethod | ||
| @pytest.mark.parametrize("order", ["C", "F", None]) | ||
| @pytest.mark.parametrize("with_config", [True, False]) | ||
| def test_order( |
There was a problem hiding this comment.
I've merged this with another existing test to reduce duplication - they were doing a lot of the same things.
|
I will definitely add more tests to get test coverage up to 100%, so this isn't quite ready yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is many fixes to how 'order' is handled. See the changelong entries for details of bugs fixed.
Fixes #2948, and helps with #3072.