Prevent mode='r+' from creating new directories #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
dstansby
force-pushed
the
r+
branch
2 times, most recently
from
d84eada to
ee21ccf
Compare
dstansby
force-pushed
the
r+
branch
2 times, most recently
from
8ddf8d4 to
9342439
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3307 +/- ##
=======================================
Coverage 94.54% 94.55%
=======================================
Files 78 78
Lines 9423 9435 +12
=======================================
+ Hits 8909 8921 +12
Misses 514 514
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3295. I'm not sure if I came up with the most elegant solution, but I couldn't think of a way to solve this without passing the mode to
LocalStore.open(). Other suggestions very welcome if anyone has any better ideas?