Skip to content

chore/add missing tests #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Aug 6, 2025

This PR excludes some unreachable lines of code from test coverage, and adds tests for a few missing routines in zarr.api.asynchronous.

I put those missing tests in a new directory to ensure that the tests are found in a location that matches the layout of the source code (unlike our current api tests). Eventually we should move all of the tests in tests/test_api.py to tests/test_api/test_asynchronous.py or tests/test_api/test_synchronous.py.

I did not add a test for api.asynchronous.open_like because it's broken. see #3352 .

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 6, 2025
@d-v-b d-v-b requested a review from a team August 6, 2025 12:32
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.64%. Comparing base (926a52f) to head (f6016db).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3353      +/-   ##
==========================================
+ Coverage   94.54%   94.64%   +0.10%     
==========================================
  Files          78       78              
  Lines        9423     9420       -3     
==========================================
+ Hits         8909     8916       +7     
+ Misses        514      504      -10     
Files with missing lines Coverage Δ
src/zarr/abc/codec.py 98.50% <ø> (+4.22%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant