Added ArrayNotFoundError #3367
Open
Added ArrayNotFoundError #3367
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
|
thank you, this looks good. we should make sure we cover all the places in the codebase where we try to read an array. maybe it's just the 1 place you found, but we should double-check. |
dstansby
suggested changes
Aug 12, 2025
| @@ -161,7 +166,7 @@ async def test_open_array(memory_store: MemoryStore, zarr_format: ZarrFormat) -> | |||
| assert z.read_only | |||
|
|
|||
| # path not found | |||
| with pytest.raises(FileNotFoundError): | |||
| with pytest.raises(ArrayNotFoundError): | |||
There was a problem hiding this comment.
This is currently failing the tests, because it actually raises a GroupNotFoundError now. I think the sensible thing to do here would be to create another new error, NodeNotFoundError, that is raised when a non-specific function is used (e.g., just open) to try and open either an array or a group.
| @@ -34,6 +35,10 @@ class GroupNotFoundError(BaseZarrError, FileNotFoundError): | |||
| _msg = "No group found in store {!r} at path {!r}" | |||
|
|
|||
|
|
|||
| class ArrayNotFoundError(BaseZarrError): | |||
There was a problem hiding this comment.
This should also sub-class FileNotFoundError to make sure we retain backwards compatibility.
|
it might be helpful to check out #3012, which unfortunately was too bloated to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2961
TODO:
docs/user-guide/*.rstchanges/