Skip to content

Remove quickfix for Lizard issue 66 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pascalzauberzeug merged 1 commit into from
Jan 23, 2025
Merged

Remove quickfix for Lizard issue 66 #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions rosys/hardware/battery_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ def __init__(self, robot_brain: RobotBrain, *,
{self.name}_reset = {expander.name + "." if expander else ""}Output({reset_pin})
{self.name}_status = {expander.name + "." if expander else ""}Input({status_pin})
''')
if expander:
lizard_code += remove_indentation(f'''
# TODO: remove when lizard issue 66 is fixed.
{self.name}_status.level = 0
{self.name}_status.active = false
''')
core_message_fields = [f'{self.name}_status.level']
super().__init__(robot_brain=robot_brain, lizard_code=lizard_code, core_message_fields=core_message_fields)

Expand Down
7 changes: 0 additions & 7 deletions rosys/hardware/bumper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import abc

from ..event import Event
from ..helpers import remove_indentation
from .estop import EStop
from .expander import ExpanderHardware
from .module import Module, ModuleHardware, ModuleSimulation
Expand Down Expand Up @@ -38,12 +37,6 @@ def __init__(self, robot_brain: RobotBrain, *,
lizard_code = ''
for pin, number in pins.items():
lizard_code += f'{name}_{pin} = {expander.name + "." if expander else ""}Input({number})\n'
if expander:
lizard_code += remove_indentation(f'''
# TODO: remove when lizard issue 66 is fixed.
{name}_{pin}.level = 0
{name}_{pin}.active = false
''')
core_message_fields = [f'{name}_{pin}.level' for pin in pins]
super().__init__(robot_brain=robot_brain,
lizard_code=lizard_code,
Expand Down
Loading