-
Notifications
You must be signed in to change notification settings - Fork 14
Update OpenCV to 4.18.X and allow numpy 2.X #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There seem to be some issues with opencv`s jpeg encode/ decode. Let's wait for #356 where we use PIL and TurboJPEG instead. |
NOTE: the conrtib modules includes the regular module
falkoschindler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are still failing 🫤
|
yes... |
dev: do not let mypy follow numpy and cv2 imports
falkoschindler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, some of the newly required type annotations feel a bit redundand, but I guess we can't do much about it.
In d4e292e I made just some minor changes:
- improved the computation of percentiles to get all five values in one pass,
- refactored the instantiation of
intrinsicsto reduce the diff and avoid# type: ignore, - wrapped a very long line,
- reverted
decoded = decode_jpeg_image(...)by specifying a more precise return typeImageArray, and - using
ImageArrayin the signature orfrom_array.
Ready to merge if you agree. 👍🏻
Motivation
We are still using numpy 1.X. This is because we were stuck at on opencv 4.8 since newer versions at the time had issues with the omnidir camera calibration module. This seems to have been fixed and as such we want to allow newer numpy versions and a new opencv minor version.
Implementation
<3.0.>=4.12.0.88(current newest) and<4.13.0.0.Progress