Add Anjoy and OpenIPC cameras to vendor list #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasNeugebauer
changed the title
NiklasNeugebauer
requested review from
Johannes-Thiel and
pascalzauberzeug
and removed request for
pascalzauberzeug
Johannes-Thiel
approved these changes
Dec 17, 2025
5 tasks
NiklasNeugebauer
pushed a commit
that referenced
this pull request
Dec 19, 2025
### Motivation #376 broke the vendor-to-url mapping for device types with more complex f-string expressions since `.format()` (apparently) cannot handle those, resulting in: `KeyError: '"sub" if substream else "main"'` ### Implementation Use a function with match instead of a dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use two new camera firmwares with rosys.
Implementation
This adds anjoy cameras with their (observed) mac range and OpenIPC cameras with the mac range that we set for them.
The functions for determining vendor and mac were also refactored to use dicts. Otherwise, we would run into a "too many return statements" Pylint error now.
Progress