Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor-base): autoRefresh addon #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tpluscode
Copy link
Collaborator

Highly anticipating v6 of CodeMirror, for now we're all but left with copying addons and converting from AMD to ES module

This adds a copy of autoRefres, complete with

@tpluscode tpluscode requested a review from martinmaillard July 2, 2021 14:15
@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2021

🦋 Changeset detected

Latest commit: 4cb6d2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rdfjs-elements/editor-base Minor
@rdfjs-elements/rdf-editor Patch
@rdfjs-elements/sparql-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

Codecov Report

Merging #72 (4731ba9) into master (ae30a0d) will decrease coverage by 0.93%.
The diff coverage is 72.91%.

❗ Current head 4731ba9 differs from pull request most recent head 29e5dfd. Consider uploading reports for the commit 29e5dfd to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   93.67%   92.74%   -0.94%     
==========================================
  Files          15       16       +1     
  Lines        1233     1281      +48     
==========================================
+ Hits         1155     1188      +33     
- Misses         78       93      +15     
Impacted Files Coverage Δ
packages/editor-base/lib/autorefresh.js 66.66% <66.66%> (ø)
packages/editor-base/index.js 97.04% <100.00%> (+0.08%) ⬆️
packages/sparql-editor/src/SparqlEditor.js 96.26% <0.00%> (-1.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae30a0d...29e5dfd. Read the comment docs.

@tpluscode tpluscode removed the request for review from martinmaillard June 13, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants