halo2_proofs: Fix oversized initialization of commitment_data.evals
#4103
Clippy (MSRV)
4 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 4 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.60.0 (7737e0b5c 2022-04-04)
- cargo 1.60.0 (d1fd9fe 2022-03-01)
- clippy 0.1.60 (7737e0b 2022-04-04)
Annotations
Check failure on line 113 in halo2_proofs/src/poly/multiopen.rs
github-actions / Clippy (MSRV)
you don't need to add `&` to all patterns
error: you don't need to add `&` to all patterns
--> halo2_proofs/src/poly/multiopen.rs:110:9
|
110 | / match self {
111 | | &CommitmentReference::Commitment(a) => std::ptr::hash(a, state),
112 | | &CommitmentReference::MSM(a) => std::ptr::hash(a, state),
113 | | }
| |_________^
|
= note: `-D clippy::match-ref-pats` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
help: instead of prefixing all patterns with `&`, you can dereference the expression
|
110 ~ match *self {
111 ~ CommitmentReference::Commitment(a) => std::ptr::hash(a, state),
112 ~ CommitmentReference::MSM(a) => std::ptr::hash(a, state),
|
Check failure on line 39 in halo2_proofs/src/poly/multiopen/verifier.rs
github-actions / Clippy (MSRV)
unnecessary closure used to substitute value for `Option::None`
error: unnecessary closure used to substitute value for `Option::None`
--> halo2_proofs/src/poly/multiopen/verifier.rs:39:9
|
39 | construct_intermediate_sets(queries).ok_or_else(|| Error::OpeningError)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `ok_or` instead: `construct_intermediate_sets(queries).ok_or(Error::OpeningError)`
|
= note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
Check failure on line 113 in halo2_proofs/src/poly/multiopen.rs
github-actions / Clippy (MSRV)
you don't need to add `&` to all patterns
error: you don't need to add `&` to all patterns
--> halo2_proofs/src/poly/multiopen.rs:110:9
|
110 | / match self {
111 | | &CommitmentReference::Commitment(a) => std::ptr::hash(a, state),
112 | | &CommitmentReference::MSM(a) => std::ptr::hash(a, state),
113 | | }
| |_________^
|
= note: `-D clippy::match-ref-pats` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
help: instead of prefixing all patterns with `&`, you can dereference the expression
|
110 ~ match *self {
111 ~ CommitmentReference::Commitment(a) => std::ptr::hash(a, state),
112 ~ CommitmentReference::MSM(a) => std::ptr::hash(a, state),
|
Check failure on line 39 in halo2_proofs/src/poly/multiopen/verifier.rs
github-actions / Clippy (MSRV)
unnecessary closure used to substitute value for `Option::None`
error: unnecessary closure used to substitute value for `Option::None`
--> halo2_proofs/src/poly/multiopen/verifier.rs:39:9
|
39 | construct_intermediate_sets(queries).ok_or_else(|| Error::OpeningError)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `ok_or` instead: `construct_intermediate_sets(queries).ok_or(Error::OpeningError)`
|
= note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations