Skip to content
CI checks

halo2_proofs: Fix oversized initialization of commitment_data.evals #4103

Sign in to view logs

halo2_proofs: Fix oversized initialization of commitment_data.evals

halo2_proofs: Fix oversized initialization of commitment_data.evals #4103

GitHub Actions / Clippy (beta) failed Jul 7, 2025 in 5s

Clippy (beta)

2 errors, 302 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 302
Note 0
Help 0

Versions

  • rustc 1.89.0-beta.3 (b5e10d8c0 2025-07-02)
  • cargo 1.89.0-beta.3 (c24e10642 2025-06-23)
  • clippy 0.1.89 (b5e10d8c00 2025-07-02)

Annotations

Check failure on line 158 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for a method 

error: missing documentation for a method
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:158:5
    |
158 |     pub fn load(&self, layouter: &mut impl Layouter<F>) -> Result<(), Error> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 174 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

missing documentation for a module 

error: missing documentation for a module
   --> halo2_gadgets/src/sinsemilla/merkle.rs:174:1
    |
174 | pub mod tests {
    | ^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> halo2_gadgets/src/lib.rs:21:9
    |
21  | #![deny(missing_docs)]
    |         ^^^^^^^^^^^^

Check warning on line 407 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

an array of `Range` that is only one element 

warning: an array of `Range` that is only one element
   --> halo2_gadgets/src/utilities.rs:407:47
    |
407 |         decompose(pallas::Base::random(rng), &[0..255]);
    |                                               ^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
    = note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::single_range_in_vec_init)]`
help: if you wanted a `Vec` that contains the entire range, try
    |
407 -         decompose(pallas::Base::random(rng), &[0..255]);
407 +         decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>());
    |
help: if you wanted an array of len 255, try
    |
407 -         decompose(pallas::Base::random(rng), &[0..255]);
407 +         decompose(pallas::Base::random(rng), &[0; 255]);
    |

Check warning on line 127 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:127:23
    |
127 |             _phantom: PhantomData::default(),
    |                       ^^^^^^^^^^^-----------
    |                                  |
    |                                  help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 118 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:118:23
    |
118 |             _phantom: PhantomData::default(),
    |                       ^^^^^^^^^^^-----------
    |                                  |
    |                                  help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 103 in halo2_gadgets/src/utilities.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
   --> halo2_gadgets/src/utilities.rs:103:23
    |
103 |             _phantom: PhantomData::default(),
    |                       ^^^^^^^^^^^-----------
    |                                  |
    |                                  help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 375 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:375:16
    |
375 |             || format!("2^(-{})", num_bits),
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
375 -             || format!("2^(-{})", num_bits),
375 +             || format!("2^(-{num_bits})"),
    |

Check warning on line 366 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:366:16
    |
366 |             || format!("element * 2^({}-{})", K, num_bits),
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
366 -             || format!("element * 2^({}-{})", K, num_bits),
366 +             || format!("element * 2^({K}-{num_bits})"),
    |

Check warning on line 331 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:331:16
    |
331 |             || format!("Range check {:?} bits", num_bits),
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
331 -             || format!("Range check {:?} bits", num_bits),
331 +             || format!("Range check {num_bits:?} bits"),
    |

Check warning on line 307 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:307:16
    |
307 |             || format!("Range check {:?} bits", num_bits),
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
307 -             || format!("Range check {:?} bits", num_bits),
307 +             || format!("Range check {num_bits:?} bits"),
    |

Check warning on line 188 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/utilities/lookup_range_check.rs:188:16
    |
188 |             || format!("{:?} words range check", num_words),
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
188 -             || format!("{:?} words range check", num_words),
188 +             || format!("{num_words:?} words range check"),
    |

Check warning on line 52 in halo2_gadgets/src/utilities/lookup_range_check.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `default` to create a unit struct 

warning: use of `default` to create a unit struct
  --> halo2_gadgets/src/utilities/lookup_range_check.rs:52:27
   |
52 |                 _phantom: PhantomData::default(),
   |                           ^^^^^^^^^^^-----------
   |                                      |
   |                                      help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

Check warning on line 660 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_gadgets/src/sinsemilla.rs:660:48
    |
660 | ...                   .chain(right.into_iter()),
    |                              ^^^^^------------
    |                                   |
    |                                   help: consider removing the `.into_iter()`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 659 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> halo2_gadgets/src/sinsemilla.rs:659:48
    |
659 | ...                   .chain(left.into_iter())
    |                              ^^^^------------
    |                                  |
    |                                  help: consider removing the `.into_iter()`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-W clippy::useless-conversion` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`

Check warning on line 136 in halo2_gadgets/src/sinsemilla.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sinsemilla.rs:136:47
    |
136 |                         layouter.namespace(|| format!("message piece {}", i)),
    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
136 -                         layouter.namespace(|| format!("message piece {}", i)),
136 +                         layouter.namespace(|| format!("message piece {i}")),
    |

Check warning on line 161 in halo2_gadgets/src/sinsemilla/merkle.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sinsemilla/merkle.rs:161:39
    |
161 |                 layouter.namespace(|| format!("MerkleCRH({}, left, right)", l)),
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
161 -                 layouter.namespace(|| format!("MerkleCRH({}, left, right)", l)),
161 +                 layouter.namespace(|| format!("MerkleCRH({l}, left, right)")),
    |

Check warning on line 328 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:328:28
    |
328 |                         || format!("l {}", l),
    |                            ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
328 -                         || format!("l {}", l),
328 +                         || format!("l {l}"),
    |

Check warning on line 301 in halo2_gadgets/src/sinsemilla/merkle/chip.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sinsemilla/merkle/chip.rs:301:35
    |
301 |             layouter.namespace(|| format!("hash at l = {}", l)),
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
301 -             layouter.namespace(|| format!("hash at l = {}", l)),
301 +             layouter.namespace(|| format!("hash at l = {l}")),
    |

Check warning on line 450 in halo2_gadgets/src/sha256/table16/spread_table.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sha256/table16/spread_table.rs:450:23
    |
450 |             Err(e) => panic!("{:?}", e),
    |                       ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
450 -             Err(e) => panic!("{:?}", e),
450 +             Err(e) => panic!("{e:?}"),
    |

Check warning on line 451 in halo2_gadgets/src/sha256/table16/message_schedule.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sha256/table16/message_schedule.rs:451:23
    |
451 |             Err(e) => panic!("{:?}", e),
    |                       ^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
451 -             Err(e) => panic!("{:?}", e),
451 +             Err(e) => panic!("{e:?}"),
    |

Check warning on line 177 in halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:177:20
    |
177 |                 || format!("carry_{}", new_word_idx),
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
177 -                 || format!("carry_{}", new_word_idx),
177 +                 || format!("carry_{new_word_idx}"),
    |

Check warning on line 171 in halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:171:20
    |
171 |                 || format!("W_{}", new_word_idx),
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
171 -                 || format!("W_{}", new_word_idx),
171 +                 || format!("W_{new_word_idx}"),
    |

Check warning on line 261 in halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:261:20
    |
261 |                 || format!("carry_{}", new_word_idx),
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
261 -                 || format!("carry_{}", new_word_idx),
261 +                 || format!("carry_{new_word_idx}"),
    |

Check warning on line 255 in halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:255:20
    |
255 |                 || format!("W_{}", new_word_idx),
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
255 -                 || format!("W_{}", new_word_idx),
255 +                 || format!("W_{new_word_idx}"),
    |

Check warning on line 173 in halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
   --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:173:16
    |
173 |             || format!("W_{}", word_idx),
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
    |
173 -             || format!("W_{}", word_idx),
173 +             || format!("W_{word_idx}"),
    |
View more details on GitHub Actions