Merge pull request #846 from zcash/bugfix #997
str4dAnnotations
284 warnings
|
an array of `Range` that is only one element:
halo2_gadgets/src/utilities.rs#L407
warning: an array of `Range` that is only one element
--> halo2_gadgets/src/utilities.rs:407:47
|
407 | decompose(pallas::Base::random(rng), &[0..255]);
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init
= note: `-W clippy::single-range-in-vec-init` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::single_range_in_vec_init)]`
help: if you wanted a `Vec` that contains the entire range, try
|
407 - decompose(pallas::Base::random(rng), &[0..255]);
407 + decompose(pallas::Base::random(rng), &(0..255).collect::<std::vec::Vec<usize>>());
|
help: if you wanted an array of len 255, try
|
407 - decompose(pallas::Base::random(rng), &[0..255]);
407 + decompose(pallas::Base::random(rng), &[0; 255]);
|
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L127
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:127:23
|
127 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L118
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:118:23
|
118 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L103
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:103:23
|
103 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L435
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:435:16
|
435 | || format!("2^(-{})", num_bits),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
435 - || format!("2^(-{})", num_bits),
435 + || format!("2^(-{num_bits})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L426
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:426:16
|
426 | || format!("element * 2^({}-{})", K, num_bits),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
426 - || format!("element * 2^({}-{})", K, num_bits),
426 + || format!("element * 2^({K}-{num_bits})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L272
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:272:16
|
272 | || format!("Range check {:?} bits", num_bits),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
272 - || format!("Range check {:?} bits", num_bits),
272 + || format!("Range check {num_bits:?} bits"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L249
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:249:16
|
249 | || format!("Range check {:?} bits", num_bits),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
249 - || format!("Range check {:?} bits", num_bits),
249 + || format!("Range check {num_bits:?} bits"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L125
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:125:16
|
125 | || format!("{:?} words range check", num_words),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
125 - || format!("{:?} words range check", num_words),
125 + || format!("{num_words:?} words range check"),
|
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities/lookup_range_check.rs#L56
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities/lookup_range_check.rs:56:27
|
56 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/sinsemilla.rs#L675
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/sinsemilla.rs:675:48
|
675 | ... .chain(right.into_iter()),
| ^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_gadgets/src/sinsemilla.rs#L674
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_gadgets/src/sinsemilla.rs:674:48
|
674 | ... .chain(left.into_iter())
| ^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla.rs#L136
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla.rs:136:47
|
136 | layouter.namespace(|| format!("message piece {}", i)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
136 - layouter.namespace(|| format!("message piece {}", i)),
136 + layouter.namespace(|| format!("message piece {i}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla/merkle.rs#L161
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla/merkle.rs:161:39
|
161 | layouter.namespace(|| format!("MerkleCRH({}, left, right)", l)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
161 - layouter.namespace(|| format!("MerkleCRH({}, left, right)", l)),
161 + layouter.namespace(|| format!("MerkleCRH({l}, left, right)")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla/merkle/chip.rs#L336
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla/merkle/chip.rs:336:28
|
336 | || format!("l {}", l),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
336 - || format!("l {}", l),
336 + || format!("l {l}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla/merkle/chip.rs#L309
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla/merkle/chip.rs:309:35
|
309 | layouter.namespace(|| format!("hash at l = {}", l)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
309 - layouter.namespace(|| format!("hash at l = {}", l)),
309 + layouter.namespace(|| format!("hash at l = {l}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/spread_table.rs#L450
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/spread_table.rs:450:23
|
450 | Err(e) => panic!("{:?}", e),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
450 - Err(e) => panic!("{:?}", e),
450 + Err(e) => panic!("{e:?}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule.rs#L451
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule.rs:451:23
|
451 | Err(e) => panic!("{:?}", e),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
451 - Err(e) => panic!("{:?}", e),
451 + Err(e) => panic!("{e:?}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L177
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:177:20
|
177 | || format!("carry_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - || format!("carry_{}", new_word_idx),
177 + || format!("carry_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L171
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:171:20
|
171 | || format!("W_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
171 - || format!("W_{}", new_word_idx),
171 + || format!("W_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L261
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:261:20
|
261 | || format!("carry_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
261 - || format!("carry_{}", new_word_idx),
261 + || format!("carry_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L255
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:255:20
|
255 | || format!("W_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
255 - || format!("W_{}", new_word_idx),
255 + || format!("W_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L173
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:173:16
|
173 | || format!("W_{}", word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
173 - || format!("W_{}", word_idx),
173 + || format!("W_{word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L168
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:168:51
|
168 | AssignedBits::<16>::assign(region, || format!("W_{}_hi", word_idx), a_4, row, w_hi_val)?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
168 - AssignedBits::<16>::assign(region, || format!("W_{}_hi", word_idx), a_4, row, w_hi_val)?
168 + AssignedBits::<16>::assign(region, || format!("W_{word_idx}_hi"), a_4, row, w_hi_val)?
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L164
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:164:51
|
164 | AssignedBits::<16>::assign(region, || format!("W_{}_lo", word_idx), a_3, row, w_lo_val)?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
164 - AssignedBits::<16>::assign(region, || format!("W_{}_lo", word_idx), a_3, row, w_lo_val)?
164 + AssignedBits::<16>::assign(region, || format!("W_{word_idx}_lo"), a_3, row, w_lo_val)?
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/compression.rs#L1001
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/compression.rs:1001:23
|
1001 | Err(e) => panic!("{:?}", e),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
1001 - Err(e) => panic!("{:?}", e),
1001 + Err(e) => panic!("{e:?}"),
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/sha256/table16/compression/compression_gates.rs#L280
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/sha256/table16/compression/compression_gates.rs:280:10
|
280 | ) -> Constraints<
| __________^
281 | | F,
282 | | (&'static str, Expression<F>),
283 | | impl Iterator<Item = (&'static str, Expression<F>)>,
284 | | > {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/sha256/table16/compression/compression_gates.rs#L105
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/sha256/table16/compression/compression_gates.rs:105:10
|
105 | ) -> Constraints<
| __________^
106 | | F,
107 | | (&'static str, Expression<F>),
108 | | impl Iterator<Item = (&'static str, Expression<F>)>,
109 | | > {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/sha256/table16/compression/compression_gates.rs#L37
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/sha256/table16/compression/compression_gates.rs:37:10
|
37 | ) -> Constraints<
| __________^
38 | | F,
39 | | (&'static str, Expression<F>),
40 | | impl Iterator<Item = (&'static str, Expression<F>)>,
41 | | > {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-W clippy::type-complexity` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::type_complexity)]`
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon.rs#L280
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon.rs:280:47
|
280 | .absorb(layouter.namespace(|| format!("absorb_{}", i)), value)?;
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
280 - .absorb(layouter.namespace(|| format!("absorb_{}", i)), value)?;
280 + .absorb(layouter.namespace(|| format!("absorb_{i}")), value)?;
|
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon.rs#L198
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon.rs:198:22
|
198 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/poseidon.rs#L152
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/poseidon.rs:152:22
|
152 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L785
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:785:32
|
785 | ... || format!("load message_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
785 - || format!("load message_{}", i),
785 + || format!("load message_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L701
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:701:32
|
701 | ... || format!("load final_state_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
701 - || format!("load final_state_{}", i),
701 + || format!("load final_state_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L662
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:662:32
|
662 | ... || format!("load state_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
662 - || format!("load state_{}", i),
662 + || format!("load state_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L586
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:586:20
|
586 | || format!("round_{} state_{}", next_round, i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
586 - || format!("round_{} state_{}", next_round, i),
586 + || format!("round_{next_round} state_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L570
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:570:20
|
570 | || format!("round_{} rc_{}", round, i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
570 - || format!("round_{} rc_{}", round, i),
570 + || format!("round_{round} rc_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L548
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:548:33
|
548 | .copy_advice(|| format!("load state_{}", i), region, config.state[i], 0)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
548 - .copy_advice(|| format!("load state_{}", i), region, config.state[i], 0)
548 + .copy_advice(|| format!("load state_{i}"), region, config.state[i], 0)
|
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L517
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:517:77
|
517 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L486
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:486:20
|
486 | || format!("round_{} partial_sbox", round),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
486 - || format!("round_{} partial_sbox", round),
486 + || format!("round_{round} partial_sbox"),
|
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L477
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:477:73
|
477 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L451
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:451:62
|
451 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect();
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L388
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:388:32
|
388 | ... || format!("load output_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
388 - || format!("load output_{}", i),
388 + || format!("load output_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L361
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:361:28
|
361 | || format!("load input_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
361 - || format!("load input_{}", i),
361 + || format!("load input_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L350
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:350:40
|
350 | ... || format!("load pad_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
350 - || format!("load pad_{}", i),
350 + || format!("load pad_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L331
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:331:32
|
331 | ... || format!("load state_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
331 - || format!("load state_{}", i),
331 + || format!("load state_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L292
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:292:28
|
292 | || format!("state_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
292 - || format!("state_{}", i),
292 + || format!("state_{i}"),
|
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L256
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:256:58
|
256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
257 | | res.and_then(|state| {
258 | | state.full_round(
259 | | &mut region,
... |
264 | | })
265 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L245
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:245:61
|
245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| {
| _____________________________________________________________^
246 | | res.and_then(|state| {
247 | | state.partial_round(
248 | | &mut region,
... |
253 | | })
254 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L241
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:241:58
|
241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
242 | | res.and_then(|state| state.full_round(&mut region, config, r, r))
243 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip.rs#L602
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip.rs:602:35
|
602 | layouter.namespace(|| format!("base-field elem fixed-base mul of {:?}", base)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
602 - layouter.namespace(|| format!("base-field elem fixed-base mul of {:?}", base)),
602 + layouter.namespace(|| format!("base-field elem fixed-base mul of {base:?}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip.rs#L588
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip.rs:588:35
|
588 | layouter.namespace(|| format!("short fixed-base mul of {:?}", base)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
588 - layouter.namespace(|| format!("short fixed-base mul of {:?}", base)),
588 + layouter.namespace(|| format!("short fixed-base mul of {base:?}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip.rs#L574
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip.rs:574:35
|
574 | layouter.namespace(|| format!("fixed-base mul of {:?}", base)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
574 - layouter.namespace(|| format!("fixed-base mul of {:?}", base)),
574 + layouter.namespace(|| format!("fixed-base mul of {base:?}")),
|
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L395
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:395:42
|
395 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L390
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:390:37
|
390 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L373
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:373:68
|
373 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0]));
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L291
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:291:20
|
291 | || format!("mul_b_y, window {}", w),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
291 - || format!("mul_b_y, window {}", w),
291 + || format!("mul_b_y, window {w}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L279
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:279:20
|
279 | || format!("mul_b_x, window {}", w),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
279 - || format!("mul_b_x, window {}", w),
279 + || format!("mul_b_x, window {w}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L241
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:241:20
|
241 | || format!("z-value for window: {:?}", window),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
241 - || format!("z-value for window: {:?}", window),
241 + || format!("z-value for window: {window:?}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L222
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:222:25
|
222 | / format!(
223 | | "Lagrange interpolation coeff for window: {:?}, k: {:?}",
224 | | window, k
225 | | )
| |_________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed/short.rs#L518
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:518:13
|
518 | format!("0x{}", s)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
518 - format!("0x{}", s)
518 + format!("0x{s}")
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed/short.rs#L514
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed/short.rs:514:21
|
514 | let s = format!("{:?}", v);
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
514 - let s = format!("{:?}", v);
514 + let s = format!("{v:?}");
|
|
|
lifetime flowing from input to output with different syntax can be confusing:
halo2_proofs/src/poly/commitment.rs#L154
warning: lifetime flowing from input to output with different syntax can be confusing
--> halo2_proofs/src/poly/commitment.rs:154:22
|
154 | pub fn empty_msm(&self) -> MSM<C> {
| ^^^^^ ------ the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
154 | pub fn empty_msm(&self) -> MSM<'_, C> {
| +++
|
|
lifetime flowing from input to output with different syntax can be confusing:
halo2_proofs/src/plonk/vanishing/verifier.rs#L92
warning: lifetime flowing from input to output with different syntax can be confusing
--> halo2_proofs/src/plonk/vanishing/verifier.rs:92:17
|
92 | params: &Params<C>,
| ^^^^^^^^^^ this lifetime flows to the output
...
96 | ) -> Evaluated<C> {
| ------------ the lifetime gets resolved as `'_`
|
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
96 | ) -> Evaluated<'_, C> {
| +++
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_proofs/src/dev.rs#L1071
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_proofs/src/dev.rs:1071:30
|
1071 | ... .fold(Ok(()), |acc, res| acc.and(res))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold((), |acc, res| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev.rs#L688
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:688:41
|
688 | / ... &util::load_instance(
689 | | ... n,
690 | | ... row,
691 | | ... &self.cs.instance_queries,
692 | | ... &self.instance,
693 | | ... ),
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
688 ~ util::load_instance(
689 + n,
690 + row,
691 + &self.cs.instance_queries,
692 + &self.instance,
693 ~ ),
|
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev.rs#L687
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:687:41
|
687 | ... &util::load(n, row, &self.cs.advice_queries, &self.advice),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, &self.advice)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev.rs#L686
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:686:41
|
686 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/graph.rs#L36
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/graph.rs:36:17
|
36 | format!("[{}] {}", gadget_name, name)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
36 - format!("[{}] {}", gadget_name, name)
36 + format!("[{gadget_name}] {name}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/graph/layout.rs#L312
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/graph/layout.rs:312:25
|
312 | format!("{} usable rows", usable_rows),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
312 - format!("{} usable rows", usable_rows),
312 + format!("{usable_rows} usable rows"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L231
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:231:13
|
231 | write!(w, "{},", query).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
231 - write!(w, "{},", query).unwrap();
231 + write!(w, "{query},").unwrap();
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L143
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:143:49
|
143 | ... (true, true) => format!("({}) * ({})", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
143 - (true, true) => format!("({}) * ({})", a, b),
143 + (true, true) => format!("({a}) * ({b})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L142
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:142:50
|
142 | ... (true, false) => format!("({}) * {}", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
142 - (true, false) => format!("({}) * {}", a, b),
142 + (true, false) => format!("({a}) * {b}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L141
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:141:50
|
141 | ... (false, true) => format!("{} * ({})", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
141 - (false, true) => format!("{} * ({})", a, b),
141 + (false, true) => format!("{a} * ({b})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L140
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:140:51
|
140 | ... (false, false) => format!("{} * {}", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
140 - (false, false) => format!("{} * {}", a, b),
140 + (false, false) => format!("{a} * {b}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L136
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:136:37
|
136 | ... format!("{} + {}", a, b)
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
136 - format!("{} + {}", a, b)
136 + format!("{a} + {b}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L134
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:134:37
|
134 | ... format!("{} - {}", a, b)
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
134 - format!("{} - {}", a, b)
134 + format!("{a} - {b}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L129
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:129:37
|
129 | ... format!("-{}", a)
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
129 - format!("-{}", a)
129 + format!("-{a}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L127
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:127:37
|
127 | ... format!("-({})", a)
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
127 - format!("-({})", a)
127 + format!("-({a})")
|
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L414
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:414:22
|
414 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:371:22
|
371 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:328:22
|
328 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:220:45
|
220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:217:42
|
217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:200:53
|
200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
doc list item without indentation:
halo2_gadgets/src/ecc/chip/constants.rs#L111
warning: doc list item without indentation
--> halo2_gadgets/src/ecc/chip/constants.rs:111:5
|
111 | /// If successful, return a vector of `(z: u64, us: [C::Base; H])` for each window.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `-W clippy::doc-lazy-continuation` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::doc_lazy_continuation)]`
help: indent this line
|
111 | /// If successful, return a vector of `(z: u64, us: [C::Base; H])` for each window.
| ++
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L562
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:562:18
|
562 | _ => eprintln!("{}", self),
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
562 - _ => eprintln!("{}", self),
562 + _ => eprintln!("{self}"),
|
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:72:53
|
72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:65:38
|
65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:52:57
|
52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L528
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:528:13
|
528 | eprintln!(" | x{} = {}", i, value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
528 - eprintln!(" | x{} = {}", i, value);
528 + eprintln!(" | x{i} = {value}");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L506
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:506:28
|
506 | .or_insert(format!("x{}", i));
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
506 - .or_insert(format!("x{}", i));
506 + .or_insert(format!("x{i}"));
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L374
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:374:9
|
374 | eprintln!(" x{} = {}", i, value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
374 - eprintln!(" x{} = {}", i, value);
374 + eprintln!(" x{i} = {value}");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L349
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:349:24
|
349 | .or_insert(format!("x{}", i));
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
349 - .or_insert(format!("x{}", i));
349 + .or_insert(format!("x{i}"));
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L287
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:287:21
|
287 | format!("x{}", i)
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
287 - format!("x{}", i)
287 + format!("x{i}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L240
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:240:17
|
240 | / write!(
241 | | f,
242 | | "Equality constraint not satisfied by cell ({:?}, {})",
243 | | column, location
244 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L238
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:238:18
|
238 | } => write!(f, "Lookup {} is not satisfied {}", lookup_index, location),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
238 - } => write!(f, "Lookup {} is not satisfied {}", lookup_index, location),
238 + } => write!(f, "Lookup {lookup_index} is not satisfied {location}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L229
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:229:17
|
229 | / write!(
230 | | f,
231 | | "{} is active on an unusable row - missing selector?",
232 | | constraint
233 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L222
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:222:17
|
222 | writeln!(f, "{} is not satisfied {}", constraint, location)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
222 - writeln!(f, "{} is not satisfied {}", constraint, location)?;
222 + writeln!(f, "{constraint} is not satisfied {location}")?;
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L198
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:198:17
|
198 | / write!(
199 | | f,
200 | | "{} uses {} at offset {}, which requires cell in column {:?} at offset {} to be assigned.",
201 | | region, gate, gate_offset, column, offset
202 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L41
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:41:17
|
41 | write!(f, "outside any region, on row {}", row)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
41 - write!(f, "outside any region, on row {}", row)
41 + write!(f, "outside any region, on row {row}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L39
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:39:50
|
39 | Self::InRegion { region, offset } => write!(f, "in {} at offset {}", region, offset),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
39 - Self::InRegion { region, offset } => write!(f, "in {} at offset {}", region, offset),
39 + Self::InRegion { region, offset } => write!(f, "in {region} at offset {offset}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L154
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:154:29
|
154 | (true, true) => format!("({}) * ({})", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
154 - (true, true) => format!("({}) * ({})", a, b),
154 + (true, true) => format!("({a}) * ({b})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L153
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:153:30
|
153 | (true, false) => format!("({}) * {}", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
153 - (true, false) => format!("({}) * {}", a, b),
153 + (true, false) => format!("({a}) * {b}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L152
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:152:30
|
152 | (false, true) => format!("{} * ({})", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
152 - (false, true) => format!("{} * ({})", a, b),
152 + (false, true) => format!("{a} * ({b})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L147
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:147:17
|
147 | format!("{} + {}", a, b)
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
147 - format!("{} + {}", a, b)
147 + format!("{a} + {b}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L145
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:145:17
|
145 | format!("{} - {}", a, b)
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
145 - format!("{} - {}", a, b)
145 + format!("{a} - {b}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L140
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:140:17
|
140 | format!("-{}", a)
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
140 - format!("-{}", a)
140 + format!("-{a}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L138
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:138:17
|
138 | format!("-({})", a)
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
138 - format!("-({})", a)
138 + format!("-({a})")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L72
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:72:5
|
72 | eprint!("{} +--------+", prefix);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
72 - eprint!("{} +--------+", prefix);
72 + eprint!("{prefix} +--------+");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L46
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:46:13
|
46 | eprint!("{} |Rotation|", prefix);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
46 - eprint!("{} |Rotation|", prefix);
46 + eprint!("{prefix} |Rotation|");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L45
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:45:13
|
45 | eprintln!("{}Cell layout at row {}:", prefix, row);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
45 - eprintln!("{}Cell layout at row {}:", prefix, row);
45 + eprintln!("{prefix}Cell layout at row {row}:");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L41
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:41:13
|
41 | eprint!("{} | Offset |", prefix);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
41 - eprint!("{} | Offset |", prefix);
41 + eprint!("{prefix} | Offset |");
|
|
|
struct `Variable` is never constructed:
halo2_gadgets/src/sha256/table16/spread_table.rs#L308
warning: struct `Variable` is never constructed
--> halo2_gadgets/src/sha256/table16/spread_table.rs:308:20
|
308 | pub struct Variable(Column<Advice>, usize);
| ^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/util.rs#L71
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/util.rs:71:9
|
71 | format!("0x{}", s)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
71 - format!("0x{}", s)
71 + format!("0x{s}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/util.rs#L67
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/util.rs:67:17
|
67 | let s = format!("{:?}", v);
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
67 - let s = format!("{:?}", v);
67 + let s = format!("{v:?}");
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly.rs#L174
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly.rs:174:22
|
174 | .zip(inv_denoms.into_iter())
| ^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
this bound is already specified as the supertrait of `ExactSizeIterator`:
halo2_proofs/src/poly.rs#L167
warning: this bound is already specified as the supertrait of `ExactSizeIterator`
--> halo2_proofs/src/poly.rs:167:26
|
167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
= note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]`
help: try removing this bound
|
167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
167 + inv_denoms: impl ExactSizeIterator<Item = F>,
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly.rs#L159
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly.rs:159:14
|
159 | .zip(assigned_denominators.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/poly/evaluator.rs#L644
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/poly/evaluator.rs:644:9
|
644 | eprintln!("Testing short-chunk regression with k = {}", k);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
644 - eprintln!("Testing short-chunk regression with k = {}", k);
644 + eprintln!("Testing short-chunk regression with k = {k}");
|
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:124:25
|
124 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:78:25
|
78 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L559
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:559:20
|
559 | let xn = x.pow(&[8, 0, 0, 0]);
| ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L549
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:549:38
|
549 | points.push(domain.omega.pow(&[i, 0, 0, 0]));
| ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:319:25
|
319 | / lookups
320 | | .iter()
321 | | .flat_map(move |p| p.queries(vk, x))
| | _________________________________________________________________-
322 | || .into_iter(),
| ||________________________________________^
| |________________________________________|
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:259:25
|
259 | / lookups
260 | | .iter()
261 | | .zip(vk.cs.lookups.iter())
262 | | .flat_map(move |(p, argument)| {
... |
275 | | })
| | _______________________________-
276 | || .into_iter(),
| ||________________________________________^
| |________________________________________|
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:206:24
|
206 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:707:24
|
707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/prover.rs:599:20
|
599 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:581:28
|
581 | .chain(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:547:14
|
547 | .zip(lookup_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:546:14
|
546 | .zip(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
doc list item without indentation:
halo2_proofs/src/plonk/lookup/prover.rs#L562
warning: doc list item without indentation
--> halo2_proofs/src/plonk/lookup/prover.rs:562:5
|
562 | /// This method returns (A', S') if no errors are encountered.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
562 | /// This method returns (A', S') if no errors are encountered.
| ++
|
|
doc list item without indentation:
halo2_proofs/src/plonk/lookup/prover.rs#L74
warning: doc list item without indentation
--> halo2_proofs/src/plonk/lookup/prover.rs:74:9
|
74 | /// The Permuted<C> struct is used to update the Lookup, and is then returned.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `-W clippy::doc-lazy-continuation` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::doc_lazy_continuation)]`
help: indent this line
|
74 | /// The Permuted<C> struct is used to update the Lookup, and is then returned.
| ++
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L131
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:131:17
|
131 | / write!(
132 | | f,
133 | | "Attempted to overwrite default value {} with {} in {:?}",
134 | | default, val, col
135 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L128
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:128:17
|
128 | write!(f, "{:?} has already been used", col)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
128 - write!(f, "{:?} has already been used", col)
128 + write!(f, "{col:?} has already been used")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L122
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:122:84
|
122 | TableError::UnevenColumnLengths((col, col_len), (table, table_len)) => write!(
| ____________________________________________________________________________________^
123 | | f,
124 | | "{:?} has length {} while {:?} has length {}",
125 | | col, col_len, table, table_len
126 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L116
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:116:17
|
116 | / write!(
117 | | f,
118 | | "{:?} not fully assigned. Help: assign a value at offset 0.",
119 | | col
120 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L85
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:85:41
|
85 | Error::TableError(error) => write!(f, "{}", error)
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
85 - Error::TableError(error) => write!(f, "{}", error)
85 + Error::TableError(error) => write!(f, "{error}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L80
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:80:54
|
80 | Error::ColumnNotInPermutation(column) => write!(
| ______________________________________________________^
81 | | f,
82 | | "Column {:?} must be included in the permutation. Help: try applying `meta.enable_equalty` on the column",
83 | | column
84 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L68
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:68:60
|
68 | Error::NotEnoughRowsAvailable { current_k } => write!(
| ____________________________________________________________^
69 | | f,
70 | | "k = {} is too small for the given circuit. Try using a larger value of k",
71 | | current_k,
72 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L67
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:67:37
|
67 | Error::Transcript(e) => write!(f, "Transcript error: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
67 - Error::Transcript(e) => write!(f, "Transcript error: {}", e),
67 + Error::Transcript(e) => write!(f, "Transcript error: {e}"),
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/circuit.rs:1261:22
|
1261 | .zip(degrees.into_iter())
| ^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/circuit.rs#L893
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/circuit.rs:893:18
|
893 | .zip(self.constraints.into_iter())
| ^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/circuit.rs#L550
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/circuit.rs:550:68
|
550 | ... gadget_name = symbol.name().map(|name| format!("{:#}", name));
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
550 - gadget_name = symbol.name().map(|name| format!("{:#}", name));
550 + gadget_name = symbol.name().map(|name| format!("{name:#}"));
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/circuit/table_layouter.rs#L104
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/circuit/table_layouter.rs:104:21
|
104 | format!("{:?}", value),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
104 - format!("{:?}", value),
104 + format!("{value:?}"),
|
|
|
struct `MyQuery` is never constructed:
halo2_proofs/src/poly/multiopen.rs#L488
warning: struct `MyQuery` is never constructed
--> halo2_proofs/src/poly/multiopen.rs:488:12
|
488 | struct MyQuery<F> {
| ^^^^^^^
|
|
struct `PointIndex` is never constructed:
halo2_proofs/src/plonk/circuit.rs#L769
warning: struct `PointIndex` is never constructed
--> halo2_proofs/src/plonk/circuit.rs:769:19
|
769 | pub(crate) struct PointIndex(pub usize);
| ^^^^^^^^^^
|
|
trait `IndexedParallelIterator` is never used:
halo2_proofs/src/multicore.rs#L28
warning: trait `IndexedParallelIterator` is never used
--> halo2_proofs/src/multicore.rs:28:11
|
28 | pub trait IndexedParallelIterator: std::iter::Iterator {}
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/poseidon.rs#L127
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/poseidon.rs:127:25
|
127 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/benches/poseidon.rs#L92
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/benches/poseidon.rs:92:28
|
92 | || format!("load message_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
92 - || format!("load message_{}", i),
92 + || format!("load message_{i}"),
|
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L127
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:127:23
|
127 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L118
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:118:23
|
118 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_gadgets/src/utilities.rs#L103
warning: use of `default` to create a unit struct
--> halo2_gadgets/src/utilities.rs:103:23
|
103 | _phantom: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L435
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:435:16
|
435 | || format!("2^(-{})", num_bits),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
435 - || format!("2^(-{})", num_bits),
435 + || format!("2^(-{num_bits})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L272
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:272:16
|
272 | || format!("Range check {:?} bits", num_bits),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
272 - || format!("Range check {:?} bits", num_bits),
272 + || format!("Range check {num_bits:?} bits"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/utilities/lookup_range_check.rs#L249
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/utilities/lookup_range_check.rs:249:16
|
249 | || format!("Range check {:?} bits", num_bits),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
249 - || format!("Range check {:?} bits", num_bits),
249 + || format!("Range check {num_bits:?} bits"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla.rs#L136
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla.rs:136:47
|
136 | layouter.namespace(|| format!("message piece {}", i)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
136 - layouter.namespace(|| format!("message piece {}", i)),
136 + layouter.namespace(|| format!("message piece {i}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla/merkle.rs#L161
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla/merkle.rs:161:39
|
161 | layouter.namespace(|| format!("MerkleCRH({}, left, right)", l)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
161 - layouter.namespace(|| format!("MerkleCRH({}, left, right)", l)),
161 + layouter.namespace(|| format!("MerkleCRH({l}, left, right)")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla/merkle/chip.rs#L336
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla/merkle/chip.rs:336:28
|
336 | || format!("l {}", l),
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
336 - || format!("l {}", l),
336 + || format!("l {l}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sinsemilla/merkle/chip.rs#L309
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sinsemilla/merkle/chip.rs:309:35
|
309 | layouter.namespace(|| format!("hash at l = {}", l)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
309 - layouter.namespace(|| format!("hash at l = {}", l)),
309 + layouter.namespace(|| format!("hash at l = {l}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L177
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:177:20
|
177 | || format!("carry_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
177 - || format!("carry_{}", new_word_idx),
177 + || format!("carry_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L171
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:171:20
|
171 | || format!("W_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
171 - || format!("W_{}", new_word_idx),
171 + || format!("W_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L261
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:261:20
|
261 | || format!("carry_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
261 - || format!("carry_{}", new_word_idx),
261 + || format!("carry_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L255
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:255:20
|
255 | || format!("W_{}", new_word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
255 - || format!("W_{}", new_word_idx),
255 + || format!("W_{new_word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L173
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:173:16
|
173 | || format!("W_{}", word_idx),
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
173 - || format!("W_{}", word_idx),
173 + || format!("W_{word_idx}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L168
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:168:51
|
168 | AssignedBits::<16>::assign(region, || format!("W_{}_hi", word_idx), a_4, row, w_hi_val)?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
168 - AssignedBits::<16>::assign(region, || format!("W_{}_hi", word_idx), a_4, row, w_hi_val)?
168 + AssignedBits::<16>::assign(region, || format!("W_{word_idx}_hi"), a_4, row, w_hi_val)?
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L164
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:164:51
|
164 | AssignedBits::<16>::assign(region, || format!("W_{}_lo", word_idx), a_3, row, w_lo_val)?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
164 - AssignedBits::<16>::assign(region, || format!("W_{}_lo", word_idx), a_3, row, w_lo_val)?
164 + AssignedBits::<16>::assign(region, || format!("W_{word_idx}_lo"), a_3, row, w_lo_val)?
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
halo2_gadgets/src/sha256/table16/compression/compression_gates.rs#L105
warning: very complex type used. Consider factoring parts into `type` definitions
--> halo2_gadgets/src/sha256/table16/compression/compression_gates.rs:105:10
|
105 | ) -> Constraints<
| __________^
106 | | F,
107 | | (&'static str, Expression<F>),
108 | | impl Iterator<Item = (&'static str, Expression<F>)>,
109 | | > {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon.rs#L280
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon.rs:280:47
|
280 | .absorb(layouter.namespace(|| format!("absorb_{}", i)), value)?;
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
280 - .absorb(layouter.namespace(|| format!("absorb_{}", i)), value)?;
280 + .absorb(layouter.namespace(|| format!("absorb_{i}")), value)?;
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L586
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:586:20
|
586 | || format!("round_{} state_{}", next_round, i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
586 - || format!("round_{} state_{}", next_round, i),
586 + || format!("round_{next_round} state_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L570
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:570:20
|
570 | || format!("round_{} rc_{}", round, i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
570 - || format!("round_{} rc_{}", round, i),
570 + || format!("round_{round} rc_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L486
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:486:20
|
486 | || format!("round_{} partial_sbox", round),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
486 - || format!("round_{} partial_sbox", round),
486 + || format!("round_{round} partial_sbox"),
|
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L477
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:477:73
|
477 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L451
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:451:62
|
451 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect();
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L388
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:388:32
|
388 | ... || format!("load output_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
388 - || format!("load output_{}", i),
388 + || format!("load output_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L361
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:361:28
|
361 | || format!("load input_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
361 - || format!("load input_{}", i),
361 + || format!("load input_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L350
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:350:40
|
350 | ... || format!("load pad_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
350 - || format!("load pad_{}", i),
350 + || format!("load pad_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L331
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:331:32
|
331 | ... || format!("load state_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
331 - || format!("load state_{}", i),
331 + || format!("load state_{i}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/poseidon/pow5.rs#L292
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/poseidon/pow5.rs:292:28
|
292 | || format!("state_{}", i),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
292 - || format!("state_{}", i),
292 + || format!("state_{i}"),
|
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L256
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:256:58
|
256 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
257 | | res.and_then(|state| {
258 | | state.full_round(
259 | | &mut region,
... |
264 | | })
265 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L245
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:245:61
|
245 | let state = (0..config.half_partial_rounds).fold(Ok(state), |res, r| {
| _____________________________________________________________^
246 | | res.and_then(|state| {
247 | | state.partial_round(
248 | | &mut region,
... |
253 | | })
254 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
halo2_gadgets/src/poseidon/pow5.rs#L241
warning: usage of `Iterator::fold` on a type that implements `Try`
--> halo2_gadgets/src/poseidon/pow5.rs:241:58
|
241 | let state = (0..config.half_full_rounds).fold(Ok(state), |res, r| {
| __________________________________________________________^
242 | | res.and_then(|state| state.full_round(&mut region, config, r, r))
243 | | })?;
| |__________________^ help: use `try_fold` instead: `try_fold(state, |res, r| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `-W clippy::manual-try-fold` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::manual_try_fold)]`
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip.rs#L602
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip.rs:602:35
|
602 | layouter.namespace(|| format!("base-field elem fixed-base mul of {:?}", base)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
602 - layouter.namespace(|| format!("base-field elem fixed-base mul of {:?}", base)),
602 + layouter.namespace(|| format!("base-field elem fixed-base mul of {base:?}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip.rs#L588
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip.rs:588:35
|
588 | layouter.namespace(|| format!("short fixed-base mul of {:?}", base)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
588 - layouter.namespace(|| format!("short fixed-base mul of {:?}", base)),
588 + layouter.namespace(|| format!("short fixed-base mul of {base:?}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip.rs#L574
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip.rs:574:35
|
574 | layouter.namespace(|| format!("fixed-base mul of {:?}", base)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
574 - layouter.namespace(|| format!("fixed-base mul of {:?}", base)),
574 + layouter.namespace(|| format!("fixed-base mul of {base:?}")),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L291
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:291:20
|
291 | || format!("mul_b_y, window {}", w),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
291 - || format!("mul_b_y, window {}", w),
291 + || format!("mul_b_y, window {w}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L279
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:279:20
|
279 | || format!("mul_b_x, window {}", w),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
279 - || format!("mul_b_x, window {}", w),
279 + || format!("mul_b_x, window {w}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L241
warning: variables can be used directly in the `format!` string
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:241:20
|
241 | || format!("z-value for window: {:?}", window),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
241 - || format!("z-value for window: {:?}", window),
241 + || format!("z-value for window: {window:?}"),
|
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:220:45
|
220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:217:42
|
217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:200:53
|
200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
doc list item without indentation:
halo2_gadgets/src/ecc/chip/constants.rs#L111
warning: doc list item without indentation
--> halo2_gadgets/src/ecc/chip/constants.rs:111:5
|
111 | /// If successful, return a vector of `(z: u64, us: [C::Base; H])` for each window.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `-W clippy::doc-lazy-continuation` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::doc_lazy_continuation)]`
help: indent this line
|
111 | /// If successful, return a vector of `(z: u64, us: [C::Base; H])` for each window.
| ++
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:72:53
|
72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:65:38
|
65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:52:57
|
52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/lib.rs#L448
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/lib.rs:448:22
|
448 | _domain: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
variables can be used directly in the `format!` string:
halo2_poseidon/src/lib.rs#L395
warning: variables can be used directly in the `format!` string
--> halo2_poseidon/src/lib.rs:395:9
|
395 | format!("ConstantLength<{}>", L)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
395 - format!("ConstantLength<{}>", L)
395 + format!("ConstantLength<{L}>")
|
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/lib.rs#L342
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/lib.rs:342:22
|
342 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/lib.rs#L305
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/lib.rs:305:22
|
305 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/p128pow5t3.rs#L90
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/p128pow5t3.rs:90:27
|
90 | P128Pow5T3Gen(PhantomData::default())
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/grain.rs#L72
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/grain.rs:72:21
|
72 | _field: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:109:13
|
109 | /// Selector assignments used for optimization pass
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
110 | selectors: vec![vec![false; n]; num_selectors],
| ---------------------------------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:107:13
|
107 | /// Pairs of cells between which we have equality constraints.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
108 | equality: vec![],
| ---------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:105:13
|
105 | /// Any cells assigned outside of a region.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
106 | loose_cells: vec![],
| ------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
= note: `#[warn(unused_doc_comments)]` on by default
|
|
unused imports: `ParallelIterator` and `Scope`:
halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator` and `Scope`
--> halo2_proofs/src/multicore.rs:15:34
|
15 | iter::{IntoParallelIterator, ParallelIterator},
| ^^^^^^^^^^^^^^^^
16 | join, scope, Scope,
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
variables can be used directly in the `format!` string:
halo2_proofs/examples/cost-model.rs#L297
warning: variables can be used directly in the `format!` string
--> halo2_proofs/examples/cost-model.rs:297:5
|
297 | println!("{:#?}", c);
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
297 - println!("{:#?}", c);
297 + println!("{c:#?}");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/tests/plonk_api.rs#L440
warning: variables can be used directly in the `format!` string
--> halo2_proofs/tests/plonk_api.rs:440:19
|
440 | Err(e) => panic!("{:?}", e),
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
440 - Err(e) => panic!("{:?}", e),
440 + Err(e) => panic!("{e:?}"),
|
|
|
struct `Variable` is never constructed:
halo2_proofs/tests/plonk_api.rs#L26
warning: struct `Variable` is never constructed
--> halo2_proofs/tests/plonk_api.rs:26:16
|
26 | pub struct Variable(Column<Advice>, usize);
| ^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
struct `Variable` is never constructed:
halo2_proofs/benches/plonk.rs#L19
warning: struct `Variable` is never constructed
--> halo2_proofs/benches/plonk.rs:19:16
|
19 | pub struct Variable(Column<Advice>, usize);
| ^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
variables can be used directly in the `format!` string:
halo2_proofs/benches/dev_lookup.rs#L63
warning: variables can be used directly in the `format!` string
--> halo2_proofs/benches/dev_lookup.rs:63:32
|
63 | ... || format!("row {}", row),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
63 - || format!("row {}", row),
63 + || format!("row {row}"),
|
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/lib.rs#L448
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/lib.rs:448:22
|
448 | _domain: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
variables can be used directly in the `format!` string:
halo2_poseidon/src/lib.rs#L395
warning: variables can be used directly in the `format!` string
--> halo2_poseidon/src/lib.rs:395:9
|
395 | format!("ConstantLength<{}>", L)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
395 - format!("ConstantLength<{}>", L)
395 + format!("ConstantLength<{L}>")
|
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/lib.rs#L342
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/lib.rs:342:22
|
342 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/lib.rs#L305
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/lib.rs:305:22
|
305 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_poseidon/src/grain.rs#L72
warning: use of `default` to create a unit struct
--> halo2_poseidon/src/grain.rs:72:21
|
72 | _field: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
lifetime flowing from input to output with different syntax can be confusing:
halo2_proofs/src/poly/commitment.rs#L154
warning: lifetime flowing from input to output with different syntax can be confusing
--> halo2_proofs/src/poly/commitment.rs:154:22
|
154 | pub fn empty_msm(&self) -> MSM<C> {
| ^^^^^ ------ the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
154 | pub fn empty_msm(&self) -> MSM<'_, C> {
| +++
|
|
lifetime flowing from input to output with different syntax can be confusing:
halo2_proofs/src/plonk/vanishing/verifier.rs#L92
warning: lifetime flowing from input to output with different syntax can be confusing
--> halo2_proofs/src/plonk/vanishing/verifier.rs:92:17
|
92 | params: &Params<C>,
| ^^^^^^^^^^ this lifetime flows to the output
...
96 | ) -> Evaluated<C> {
| ------------ the lifetime gets resolved as `'_`
|
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
96 | ) -> Evaluated<'_, C> {
| +++
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev.rs#L688
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:688:41
|
688 | / ... &util::load_instance(
689 | | ... n,
690 | | ... row,
691 | | ... &self.cs.instance_queries,
692 | | ... &self.instance,
693 | | ... ),
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
688 ~ util::load_instance(
689 + n,
690 + row,
691 + &self.cs.instance_queries,
692 + &self.instance,
693 ~ ),
|
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev.rs#L687
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:687:41
|
687 | ... &util::load(n, row, &self.cs.advice_queries, &self.advice),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, &self.advice)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev.rs#L686
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:686:41
|
686 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/graph.rs#L36
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/graph.rs:36:17
|
36 | format!("[{}] {}", gadget_name, name)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
36 - format!("[{}] {}", gadget_name, name)
36 + format!("[{gadget_name}] {name}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/graph/layout.rs#L312
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/graph/layout.rs:312:25
|
312 | format!("{} usable rows", usable_rows),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
312 - format!("{} usable rows", usable_rows),
312 + format!("{usable_rows} usable rows"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L231
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:231:13
|
231 | write!(w, "{},", query).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
231 - write!(w, "{},", query).unwrap();
231 + write!(w, "{query},").unwrap();
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L143
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:143:49
|
143 | ... (true, true) => format!("({}) * ({})", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
143 - (true, true) => format!("({}) * ({})", a, b),
143 + (true, true) => format!("({a}) * ({b})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L142
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:142:50
|
142 | ... (true, false) => format!("({}) * {}", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
142 - (true, false) => format!("({}) * {}", a, b),
142 + (true, false) => format!("({a}) * {b}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L141
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:141:50
|
141 | ... (false, true) => format!("{} * ({})", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
141 - (false, true) => format!("{} * ({})", a, b),
141 + (false, true) => format!("{a} * ({b})"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L140
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:140:51
|
140 | ... (false, false) => format!("{} * {}", a, b),
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
140 - (false, false) => format!("{} * {}", a, b),
140 + (false, false) => format!("{a} * {b}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L136
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:136:37
|
136 | ... format!("{} + {}", a, b)
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
136 - format!("{} + {}", a, b)
136 + format!("{a} + {b}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/gates.rs#L127
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/gates.rs:127:37
|
127 | ... format!("-({})", a)
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
127 - format!("-({})", a)
127 + format!("-({a})")
|
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L371
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:371:22
|
371 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/dev/cost.rs#L328
warning: use of `default` to create a unit struct
--> halo2_proofs/src/dev/cost.rs:328:22
|
328 | _marker: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L562
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:562:18
|
562 | _ => eprintln!("{}", self),
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
562 - _ => eprintln!("{}", self),
562 + _ => eprintln!("{self}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L528
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:528:13
|
528 | eprintln!(" | x{} = {}", i, value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
528 - eprintln!(" | x{} = {}", i, value);
528 + eprintln!(" | x{i} = {value}");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L506
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:506:28
|
506 | .or_insert(format!("x{}", i));
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
506 - .or_insert(format!("x{}", i));
506 + .or_insert(format!("x{i}"));
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L374
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:374:9
|
374 | eprintln!(" x{} = {}", i, value);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
374 - eprintln!(" x{} = {}", i, value);
374 + eprintln!(" x{i} = {value}");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L349
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:349:24
|
349 | .or_insert(format!("x{}", i));
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
349 - .or_insert(format!("x{}", i));
349 + .or_insert(format!("x{i}"));
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L238
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:238:18
|
238 | } => write!(f, "Lookup {} is not satisfied {}", lookup_index, location),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
238 - } => write!(f, "Lookup {} is not satisfied {}", lookup_index, location),
238 + } => write!(f, "Lookup {lookup_index} is not satisfied {location}"),
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L229
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:229:17
|
229 | / write!(
230 | | f,
231 | | "{} is active on an unusable row - missing selector?",
232 | | constraint
233 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L224
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:224:21
|
224 | writeln!(f, "- {} = {}", name, value)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
224 - writeln!(f, "- {} = {}", name, value)?;
224 + writeln!(f, "- {name} = {value}")?;
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L222
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:222:17
|
222 | writeln!(f, "{} is not satisfied {}", constraint, location)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
222 - writeln!(f, "{} is not satisfied {}", constraint, location)?;
222 + writeln!(f, "{constraint} is not satisfied {location}")?;
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure.rs#L211
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure.rs:211:17
|
211 | / write!(
212 | | f,
213 | | "{} uses {} at offset {}, which requires cell in instance column {:?} at row {} to be assigned.",
214 | | region, gate, gate_offset, column, row
215 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L140
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:140:17
|
140 | format!("-{}", a)
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
140 - format!("-{}", a)
140 + format!("-{a}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L138
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:138:17
|
138 | format!("-({})", a)
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
138 - format!("-({})", a)
138 + format!("-({a})")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L72
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:72:5
|
72 | eprint!("{} +--------+", prefix);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
72 - eprint!("{} +--------+", prefix);
72 + eprint!("{prefix} +--------+");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L46
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:46:13
|
46 | eprint!("{} |Rotation|", prefix);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
46 - eprint!("{} |Rotation|", prefix);
46 + eprint!("{prefix} |Rotation|");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L45
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:45:13
|
45 | eprintln!("{}Cell layout at row {}:", prefix, row);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
45 - eprintln!("{}Cell layout at row {}:", prefix, row);
45 + eprintln!("{prefix}Cell layout at row {row}:");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/failure/emitter.rs#L41
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/failure/emitter.rs:41:13
|
41 | eprint!("{} | Offset |", prefix);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
41 - eprint!("{} | Offset |", prefix);
41 + eprint!("{prefix} | Offset |");
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/util.rs#L71
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/util.rs:71:9
|
71 | format!("0x{}", s)
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
71 - format!("0x{}", s)
71 + format!("0x{s}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/dev/util.rs#L67
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/dev/util.rs:67:17
|
67 | let s = format!("{:?}", v);
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
67 - let s = format!("{:?}", v);
67 + let s = format!("{v:?}");
|
|
|
this bound is already specified as the supertrait of `ExactSizeIterator`:
halo2_proofs/src/poly.rs#L167
warning: this bound is already specified as the supertrait of `ExactSizeIterator`
--> halo2_proofs/src/poly.rs:167:26
|
167 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
= note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]`
help: try removing this bound
|
167 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
167 + inv_denoms: impl ExactSizeIterator<Item = F>,
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/poly.rs#L159
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/poly.rs:159:14
|
159 | .zip(assigned_denominators.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L124
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:124:25
|
124 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
|
|
use of `default` to create a unit struct:
halo2_proofs/src/poly/evaluator.rs#L78
warning: use of `default` to create a unit struct
--> halo2_proofs/src/poly/evaluator.rs:78:25
|
78 | _evaluator: PhantomData::default(),
| ^^^^^^^^^^^-----------
| |
| help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `-W clippy::default-constructed-unit-structs` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::default_constructed_unit_structs)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L319
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:319:25
|
319 | / lookups
320 | | .iter()
321 | | .flat_map(move |p| p.queries(vk, x))
| | _________________________________________________________________-
322 | || .into_iter(),
| ||________________________________________^
| |________________________________________|
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/verifier.rs#L259
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/verifier.rs:259:25
|
259 | / lookups
260 | | .iter()
261 | | .zip(vk.cs.lookups.iter())
262 | | .flat_map(move |(p, argument)| {
... |
275 | | })
| | _______________________________-
276 | || .into_iter(),
| ||________________________________________^
| |________________________________________|
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L206
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:206:24
|
206 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L707
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:707:24
|
707 | .chain(lookups.iter().flat_map(move |p| p.open(pk, x)).into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/prover.rs#L599
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/prover.rs:599:20
|
599 | let xn = x.pow(&[params.n, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L581
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:581:28
|
581 | .chain(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:497:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L547
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:547:14
|
547 | .zip(lookup_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/prover.rs#L546
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/prover.rs:546:14
|
546 | .zip(permutation_expressions.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
doc list item without indentation:
halo2_proofs/src/plonk/lookup/prover.rs#L562
warning: doc list item without indentation
--> halo2_proofs/src/plonk/lookup/prover.rs:562:5
|
562 | /// This method returns (A', S') if no errors are encountered.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
562 | /// This method returns (A', S') if no errors are encountered.
| ++
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L131
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:131:17
|
131 | / write!(
132 | | f,
133 | | "Attempted to overwrite default value {} with {} in {:?}",
134 | | default, val, col
135 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L122
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:122:84
|
122 | TableError::UnevenColumnLengths((col, col_len), (table, table_len)) => write!(
| ____________________________________________________________________________________^
123 | | f,
124 | | "{:?} has length {} while {:?} has length {}",
125 | | col, col_len, table, table_len
126 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L116
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:116:17
|
116 | / write!(
117 | | f,
118 | | "{:?} not fully assigned. Help: assign a value at offset 0.",
119 | | col
120 | | )
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L85
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:85:41
|
85 | Error::TableError(error) => write!(f, "{}", error)
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
85 - Error::TableError(error) => write!(f, "{}", error)
85 + Error::TableError(error) => write!(f, "{error}")
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L80
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:80:54
|
80 | Error::ColumnNotInPermutation(column) => write!(
| ______________________________________________________^
81 | | f,
82 | | "Column {:?} must be included in the permutation. Help: try applying `meta.enable_equalty` on the column",
83 | | column
84 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L68
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:68:60
|
68 | Error::NotEnoughRowsAvailable { current_k } => write!(
| ____________________________________________________________^
69 | | f,
70 | | "k = {} is too small for the given circuit. Try using a larger value of k",
71 | | current_k,
72 | | ),
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/plonk/error.rs#L67
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/plonk/error.rs:67:37
|
67 | Error::Transcript(e) => write!(f, "Transcript error: {}", e),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
67 - Error::Transcript(e) => write!(f, "Transcript error: {}", e),
67 + Error::Transcript(e) => write!(f, "Transcript error: {e}"),
|
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/circuit.rs#L1261
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/circuit.rs:1261:22
|
1261 | .zip(degrees.into_iter())
| ^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
halo2_proofs/src/plonk/circuit.rs#L893
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> halo2_proofs/src/plonk/circuit.rs:893:18
|
893 | .zip(self.constraints.into_iter())
| ^^^^^^^^^^^^^^^^------------
| |
| help: consider removing the `.into_iter()`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/b5e10d8c000a153cae6a14d70372dc4b39439a3f/library/core/src/iter/traits/iterator.rs:615:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-W clippy::useless-conversion` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::useless_conversion)]`
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/circuit.rs#L550
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/circuit.rs:550:68
|
550 | ... gadget_name = symbol.name().map(|name| format!("{:#}", name));
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
550 - gadget_name = symbol.name().map(|name| format!("{:#}", name));
550 + gadget_name = symbol.name().map(|name| format!("{name:#}"));
|
|
|
variables can be used directly in the `format!` string:
halo2_proofs/src/circuit/table_layouter.rs#L104
warning: variables can be used directly in the `format!` string
--> halo2_proofs/src/circuit/table_layouter.rs:104:21
|
104 | format!("{:?}", value),
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-W clippy::uninlined-format-args` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
104 - format!("{:?}", value),
104 + format!("{value:?}"),
|
|
|
struct `PointIndex` is never constructed:
halo2_proofs/src/plonk/circuit.rs#L769
warning: struct `PointIndex` is never constructed
--> halo2_proofs/src/plonk/circuit.rs:769:19
|
769 | pub(crate) struct PointIndex(pub usize);
| ^^^^^^^^^^
|
|
trait `IndexedParallelIterator` is never used:
halo2_proofs/src/multicore.rs#L28
warning: trait `IndexedParallelIterator` is never used
--> halo2_proofs/src/multicore.rs:28:11
|
28 | pub trait IndexedParallelIterator: std::iter::Iterator {}
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L109
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:109:13
|
109 | /// Selector assignments used for optimization pass
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
110 | selectors: vec![vec![false; n]; num_selectors],
| ---------------------------------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L107
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:107:13
|
107 | /// Pairs of cells between which we have equality constraints.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
108 | equality: vec![],
| ---------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
|
|
unused doc comment:
halo2_proofs/src/dev/cost.rs#L105
warning: unused doc comment
--> halo2_proofs/src/dev/cost.rs:105:13
|
105 | /// Any cells assigned outside of a region.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
106 | loose_cells: vec![],
| ------------------- rustdoc does not generate documentation for expression fields
|
= help: use `//` for a plain comment
= note: `#[warn(unused_doc_comments)]` on by default
|
|
unused imports: `ParallelIterator` and `Scope`:
halo2_proofs/src/multicore.rs#L15
warning: unused imports: `ParallelIterator` and `Scope`
--> halo2_proofs/src/multicore.rs:15:34
|
15 | iter::{IntoParallelIterator, ParallelIterator},
| ^^^^^^^^^^^^^^^^
16 | join, scope, Scope,
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|