Skip to content

Add P2SH multisig support to pczt commands #478

Add P2SH multisig support to pczt commands

Add P2SH multisig support to pczt commands #478

Triggered via pull request July 29, 2025 13:53
@str4dstr4d
synchronize #108
pczt-multisig
Status Failure
Total duration 6m 0s
Artifacts

ci.yml

on: pull_request
Matrix: build-latest
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 4 notices
variables can be used directly in the `format!` string: src/main.rs#L214
error: variables can be used directly in the `format!` string --> src/commands/pczt/inspect.rs:214:41 | 214 | ... println!(" {:?}", derivation_path); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-D clippy::uninlined-format-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]` help: change this to | 214 - println!(" {:?}", derivation_path); 214 + println!(" {derivation_path:?}"); |
the borrowed expression implements the required traits: src/main.rs#L125
error: the borrowed expression implements the required traits --> src/commands/pczt/create_manual.rs:125:48 | 125 | let script_bytes = hex::decode(&script_hex)?; | ^^^^^^^^^^^ help: change this to: `script_hex` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
using `clone` on type `PublicKey` which implements the `Copy` trait: src/main.rs#L122
error: using `clone` on type `PublicKey` which implements the `Copy` trait --> src/commands/pczt/create_manual.rs:122:25 | 122 | pubkey: pubkey.clone(), | ^^^^^^^^^^^^^^ help: try dereferencing it: `*pubkey` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`
the borrowed expression implements the required traits: src/main.rs#L264
error: the borrowed expression implements the required traits --> src/commands/inspect/context.rs:264:47 | 264 | serializer.serialize_str(&hex::encode(&self.0.to_bytes())) | ^^^^^^^^^^^^^^^^^^ help: change this to: `self.0.to_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: src/main.rs#L81
error: the borrowed expression implements the required traits --> src/commands/create_multisig_address.rs:81:62 | 81 | let script_id = ripemd::Ripemd160::digest(Sha256::digest(&multisig_redeem_script.to_bytes())); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `multisig_redeem_script.to_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]`
Build latest on macOS-latest
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
Build latest on macOS-latest
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
Build on macOS-latest
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520
Build on macOS-latest
The macos-latest label will migrate to macOS 15 beginning August 4, 2025. For more information see https://github.com/actions/runner-images/issues/12520