Skip to content

fix(self-update): respect option flags #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vladdoster wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(self-update): respect option flags #633

vladdoster wants to merge 6 commits into from

Conversation

@vladdoster
Copy link
Member

@vladdoster vladdoster commented Jan 26, 2024 •
edited
Loading

Description

Flags --help, --no-pager, and --quiet recognized by self-update command.

Related Issue(s)

Closes #632

Motivation and Context

Improve user experience

Usage examples

Screenshot 2024-01-26 at 00 10 26

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@vladdoster vladdoster mentioned this pull request Jan 26, 2024
Open
@vladdoster vladdoster force-pushed the fix/self-update branch 3 times, most recently from 74db8f7 to 3463426 Compare January 26, 2024 06:39
@github-actions github-actions bot added the tests label Jan 26, 2024
@github-actions github-actions bot added the ci/cd label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alichtman alichtman Awaiting requested review from alichtman alichtman is a code owner

@pschmitt pschmitt Awaiting requested review from pschmitt pschmitt is a code owner

Assignees

No one assigned

Labels

ci/cd completion fix release tests zinit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[maint]: Re-add --no-pager option to zinit self-update

2 participants

@vladdoster