Skip to content

Conversation

WhiskeyJack96
Copy link
Contributor

@WhiskeyJack96 WhiskeyJack96 commented Oct 11, 2025

resolves #90

Tested both the append and override flows by sending:

const resp = await this.connection.newSession({
			cwd: basePath,
			_meta: {
				systemPrompt: "you are an obsidian assistant agent, you should be helpful to the user when working with their notes"
			},
			mcpServers: []
		});
const resp = await this.connection.newSession({
			cwd: basePath,
			_meta: {
				systemPrompt: {
					append: "always speak in spanish"
				}
			},
			mcpServers: []
		});

and confirmed that in both cases those prompts are what gets sent to the agent!

Copy link

cla-bot bot commented Oct 11, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @WhiskeyJack96 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@WhiskeyJack96
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2025
Copy link

cla-bot bot commented Oct 11, 2025

The cla-bot has been summoned, and re-checked this pull request!

src/acp-agent.ts Outdated

let systemPrompt: Options["systemPrompt"] = { type: "preset", preset: "claude_code" }
if (params._meta?.systemPrompt){
if (typeof params._meta.systemPrompt === "string") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typescript isnt my strong suit, so if theres a more idiomatic way to handle the union disambiguation I'm happy to give it a go!

@benbrandt
Copy link
Member

@WhiskeyJack96 this looks great! I made the checks slightly stricter to be safe, but otherwise it makes sense to me!

@benbrandt benbrandt merged commit ea796f3 into zed-industries:main Oct 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support overriding the system prompt

2 participants