Make write and edit permissions consistent #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdeviant
changed the title
|
@WhiskeyJack96 thanks for reporting. I pushed a change to not push Write to allowed, since I'm not sure that is the desired behavior anyway... |
|
This works as expected (my integration now requires two approvals for both edit and write)! |
|
Great. It is working as expected for me as well, and we already had handling in the permissions tool that if the user allows edits than we permit the write tool, but if not, then they have to approve. Thanks for catching! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently edit requires a permissions call and write does not. This means that if clients want to allow users to approve
Writecalls they need to add handling toHandleFileWritebut if they do that then edits get two permissions checks.Alternatively we could remove the write tool from approved tools (which would make more sense to me) but I'm assuming its there for a good reason, if not happy to change to remove it instead!