Skip to content

Commit

Permalink
git_ui: horizontal is not vertical (#25961)
Browse files Browse the repository at this point in the history
Fixes an issue where I was missing some brain cells and changed the git
panel's `render_entries` to a `v_flex` instead of an `h_flex`.

But actually, fixes the git panel entries from disappearing when a
scrollbar is rendered.

**Before**

![CleanShot 2025-03-03 at 16 36
52@2x](https://github.com/user-attachments/assets/9dca7b9c-318d-4b3f-ab3e-e7242fa7f73a)

**After**

![CleanShot 2025-03-03 at 16 35
59@2x](https://github.com/user-attachments/assets/c1fe5fb1-ad57-4bca-ace4-365e70a74066)


Closes #25955

Release Notes:

- Git Beta: Fixed an issue where when the git panel would need to scroll
all the items are pushed off the screen.
  • Loading branch information
iamnbutler authored Mar 3, 2025
1 parent 0bd40da commit ac3cb3d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion crates/git_ui/src/git_panel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2274,7 +2274,7 @@ impl GitPanel {
) -> impl IntoElement {
let entry_count = self.entries.len();

v_flex()
h_flex()
.size_full()
.flex_grow()
.overflow_hidden()
Expand Down

0 comments on commit ac3cb3d

Please sign in to comment.