Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_ui: horizontal is not vertical #25961

Merged
merged 3 commits into from
Mar 3, 2025
Merged

git_ui: horizontal is not vertical #25961

merged 3 commits into from
Mar 3, 2025

Conversation

iamnbutler
Copy link
Member

Fixes an issue where I was missing some brain cells and changed the git panel's render_entries to a v_flex instead of an h_flex.

But actually, fixes the git panel entries from disappearing when a scrollbar is rendered.

Before

CleanShot 2025-03-03 at 16 36 52@2x

After

CleanShot 2025-03-03 at 16 35 59@2x

Closes #25955

Release Notes:

  • Git Beta: Fixed an issue where when the git panel would need to scroll all the items are pushed off the screen.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 3, 2025
@iamnbutler iamnbutler marked this pull request as ready for review March 3, 2025 21:37
@zed-industries-bot
Copy link

zed-industries-bot commented Mar 3, 2025

Warnings
⚠️
git_ui: horizontal is not vertical
    ^

Write PR titles using sentence case.

Have feedback on this plugin? Let's hear it!

Generated by 🚫 dangerJS against 6c22ff2

@iamnbutler iamnbutler enabled auto-merge (squash) March 3, 2025 21:50
@iamnbutler iamnbutler merged commit ac3cb3d into main Mar 3, 2025
12 checks passed
@iamnbutler iamnbutler deleted the pain branch March 3, 2025 22:00
JosephTLyons pushed a commit that referenced this pull request Mar 4, 2025
Fixes an issue where I was missing some brain cells and changed the git
panel's `render_entries` to a `v_flex` instead of an `h_flex`.

But actually, fixes the git panel entries from disappearing when a
scrollbar is rendered.

**Before**

![CleanShot 2025-03-03 at 16 36
52@2x](https://github.com/user-attachments/assets/9dca7b9c-318d-4b3f-ab3e-e7242fa7f73a)

**After**

![CleanShot 2025-03-03 at 16 35
59@2x](https://github.com/user-attachments/assets/c1fe5fb1-ad57-4bca-ace4-365e70a74066)


Closes #25955

Release Notes:

- Git Beta: Fixed an issue where when the git panel would need to scroll
all the items are pushed off the screen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git Beta: Scrollbar always setting will hide the files in the git dock
2 participants