Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchains: Run listing tasks on background thread #21414

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

osiewicz
Copy link
Contributor

@osiewicz osiewicz commented Dec 2, 2024

Potentially fixes #21404

This is a speculative fix, as while I was trying to repro this issue I've noticed that introducing artificial delays in ToolchainLister::list could impact apps responsiveness. These delays were essentially there to stimulate PET taking a while to find venvs.

Release Notes:

  • Improved app responsiveness in environments with multiple Python virtual environments

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 2, 2024
@osiewicz osiewicz merged commit 59dc6cf into main Dec 2, 2024
12 checks passed
@osiewicz osiewicz deleted the toolchains-run-detection-on-background-thread branch December 2, 2024 20:03
@osiewicz
Copy link
Contributor Author

osiewicz commented Dec 2, 2024

/cherry-pick v0.163.x

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 2, 2024
Potentially fixes #21404

This is a speculative fix, as while I was trying to repro this issue
I've noticed that introducing artificial delays in ToolchainLister::list
could impact apps responsiveness. These delays were essentially there to
stimulate PET taking a while to find venvs.

Release Notes:

- Improved app responsiveness in environments with multiple Python
virtual environments
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 2, 2024
Potentially fixes #21404

This is a speculative fix, as while I was trying to repro this issue
I've noticed that introducing artificial delays in ToolchainLister::list
could impact apps responsiveness. These delays were essentially there to
stimulate PET taking a while to find venvs.

Release Notes:

- Improved app responsiveness in environments with multiple Python
virtual environments
osiewicz added a commit that referenced this pull request Dec 2, 2024
… (#21420)

Cherry-picked toolchains: Run listing tasks on background thread
(#21414)

Potentially fixes #21404

This is a speculative fix, as while I was trying to repro this issue
I've noticed that introducing artificial delays in ToolchainLister::list
could impact apps responsiveness. These delays were essentially there to
stimulate PET taking a while to find venvs.

Release Notes:

- Improved app responsiveness in environments with multiple Python
virtual environments

Co-authored-by: Piotr Osiewicz <[email protected]>
osiewicz added a commit that referenced this pull request Dec 2, 2024
… (#21421)

Cherry-picked toolchains: Run listing tasks on background thread
(#21414)

Potentially fixes #21404

This is a speculative fix, as while I was trying to repro this issue
I've noticed that introducing artificial delays in ToolchainLister::list
could impact apps responsiveness. These delays were essentially there to
stimulate PET taking a while to find venvs.

Release Notes:

- Improved app responsiveness in environments with multiple Python
virtual environments

Co-authored-by: Piotr Osiewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any file is taking seconds to open
1 participant