Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Extra textobjects + minor changes and tests #21435

Closed

Conversation

hrou0003
Copy link
Contributor

@hrou0003 hrou0003 commented Dec 3, 2024

  • Added textobjects.scm for core and extension languages (didn't implement inheritance)
  • Tests
  • Implemented class motion by turning method_motion into text_object_motion and taking in a TextObject

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 3, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless im misunderstanding the purpose i dont think any of these are right except params and comments. function.inside is gonna match the parameters, test.inside is gonna match the test name if it has one, and all the class.insides are gonna match the first field or type modifiers like the u32 in enum(u32)

@ConradIrwin
Copy link
Member

@hrou0003 thank you for this! Sorry I was also working on this at the same time, and it's all changed quite a bit since when your PR was based on.

I am going to have to close this. I was planning to work on extension languages today too.

@ConradIrwin ConradIrwin closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants