Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: Disable commit message generation when commit not possible #26329

Merged
merged 2 commits into from
Mar 10, 2025
Merged

git: Disable commit message generation when commit not possible #26329

merged 2 commits into from
Mar 10, 2025

Conversation

0xRichardH
Copy link
Contributor

@0xRichardH 0xRichardH commented Mar 8, 2025 •
edited
Loading

Issue:

  • Generate Commit Message will generate a random message if there are no changes.
image

After Fixed:

  • Generate Commit Message will be disabled if commit is not possible
image

Release Notes:

  • Fixed: Disable commit message generation when commit is not possible

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 8, 2025
@0xRichardH 0xRichardH force-pushed the fix/do_not_generate_commit_messages_if_there_is_no_changes branch from 3fe6903 to b893eb9 Compare March 9, 2025 03:35
@mikayla-maki mikayla-maki merged commit d732b8b into zed-industries:main Mar 10, 2025
13 checks passed
@mikayla-maki
Copy link
Member

Thank you!

JosephTLyons pushed a commit that referenced this pull request Mar 10, 2025
@0xRichardH @JosephTLyons
git: Disable commit message generation when commit not possible (#26329)
4144a2e 
## Issue:

- `Generate Commit Message` will generate a random message if there are
no changes.
<img width="614" alt="image"
src="https://github.com/user-attachments/assets/c16cadac-01af-47c0-a2db-a5bbf62f84bb"
/>


## After Fixed:

- `Generate Commit Message` will be disabled if commit is not possible
<img width="610" alt="image"
src="https://github.com/user-attachments/assets/5ea9ca70-6fa3-4144-ab4e-be7a986d5496"
/>


## Release Notes:

- Fixed: Disable commit message generation when commit is not possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xRichardH @mikayla-maki