Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Highlight super and this as keywords in JS/TS/TSX" #26342

Merged

Conversation

probably-neb
Copy link
Contributor

@probably-neb probably-neb commented Mar 9, 2025

Reverts #25135

This approach was not the best as explained in the response to the original PR. Likely, the better approach is to create a newer specific scope for these kinds of variables under the @variable prefix so that themes can control these pseudo-keywords specifically

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 9, 2025
@probably-neb probably-neb enabled auto-merge (squash) March 9, 2025 15:59
@zed-industries-bot
Copy link

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 609fe86

@probably-neb probably-neb merged commit 6de3ac3 into main Mar 9, 2025
14 checks passed
@probably-neb probably-neb deleted the revert-25135-highlight-super-and-this-as-keywords-in-js branch March 9, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants