gpui_linux: Clear X11 urgency hint on focus - #62550
Open
melocene wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #61679
Solution
Clear the X11
WM_HINTSurgency flag when a window receives focus, while preserving the other window manager hints.Testing
Did you test these changes? If so, how?
cargo check -p gpui_linuxcargo test -p gpui_linux --libReviewers can reproduce #61679 on XFCE using
xprop WM_HINTSto confirm that the urgency hint is cleared after focusing Zed.Shouldn't be as this is just another method in a similar style as the existing.
Compile and run Zed on a system running XFCE4.
Arch Linux with XFCE 4.20
Self-Review Checklist:
Release Notes: