Skip to content

Use renamed thread titles in notifications - #62588

Open
cocoatoucher wants to merge 1 commit into
zed-industries:mainfrom
cocoatoucher:agent/use-renamed-thread-title-in-notifications
Open

Use renamed thread titles in notifications#62588
cocoatoucher wants to merge 1 commit into
zed-industries:mainfrom
cocoatoucher:agent/use-renamed-thread-title-in-notifications

Conversation

@cocoatoucher

Copy link
Copy Markdown

Notifications currently read the title from the live ACP thread. A user rename is stored as a metadata title override, so the notification can continue to show the original generated title.

This change makes notifications resolve the title from thread metadata first and fall back to the live ACP thread title. The same resolved title is used when the notification opens the thread. A regression test covers a thread with an original generated title and a user-supplied title override.

Validation:

  • cargo fmt --all -- --check
  • git diff --check
  • Attempted cargo test -p agent_ui test_notification_uses_renamed_thread_title; the build exhausted the available local disk space before the agent_ui test binary finished compiling.

Release Notes:

  • Fixed agent notifications to show renamed thread titles.

@cla-bot

cla-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @cocoatoucher on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Aug 13, 2026
@cocoatoucher

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot

cla-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @cocoatoucher on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot

cla-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@cocoatoucher
cocoatoucher marked this pull request as ready for review August 13, 2026 16:58
@dinocosta dinocosta added the area:ai/agent thread Feedback for Zed's Agent Thread label Aug 14, 2026

@dinocosta dinocosta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cocoatoucher ! 🙂

Overall the changes seem fine to me but, before we're able to review, we'll need you to sign the CLA.

Also, just double-checking, but have you been able to run your changes and confirm the updated behavior? If so, would you mind sharing a screen recording? I'm asking because of this bit in the Pull Request description which, even though only mentions running the test, I wonder if the same happened when trying to run a development build ▼

Attempted cargo test -p agent_ui test_notification_uses_renamed_thread_title; the build exhausted the available local disk space before the agent_ui test binary finished compiling.

Thanks!

@dinocosta dinocosta self-assigned this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ai/agent thread Feedback for Zed's Agent Thread first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants